Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Allow Mission without specifying begin and end in types.py #1949

Open
qianyi-sun opened this issue Apr 10, 2023 · 0 comments · May be fixed by #2060
Open

[Feature request] Allow Mission without specifying begin and end in types.py #1949

qianyi-sun opened this issue Apr 10, 2023 · 0 comments · May be fixed by #2060
Assignees
Labels
enhancement New feature or request

Comments

@qianyi-sun
Copy link
Contributor

qianyi-sun commented Apr 10, 2023

Proposal

In current implementation, we have Mission that allows both begin and end point and EndlessMission that allows only specifying begin point for the mission. In Mission(), if we could allow begin=None and end=None or begin=auto() and end=auto(), then EndlessMission might be no longer necessary, like:

# EndlessMission can become this
mission = types.Mission(route=Route(begin=(...), end=auto()), ...)

and,

# new implementation that allows specifying end point only
mission = types.Mission(route=Route(begin=auto(), end=(...)), entry_tactic=....)

Motivation

For some use case such as hijacking offline dataset history vehicles as agent(s), sometimes it would be useful to assign the agent(s) a different end point of interest, instead of using the original trajectory (i.e., original both begin and end). Therefore allowing a mission that only specifying end point and could be available (set begin=auto() and specify an end point in the mission).

Alternatives

Alternatively, implement a new mission type like DestinationMission in types.py that allows users to create missions without specifying start point (similiar to the EndlessMission interface but just the opposite) and EndlessMission remains unchanged, such that:

mission = types.DestinationMission(end=(....), ...)

Additional context

No response

@qianyi-sun qianyi-sun added the enhancement New feature or request label Apr 10, 2023
@Gamenot Gamenot linked a pull request Jun 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants