Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert engine constants to configuration #1854

Open
4 tasks
Gamenot opened this issue Feb 10, 2023 · 0 comments
Open
4 tasks

Convert engine constants to configuration #1854

Gamenot opened this issue Feb 10, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@Gamenot
Copy link
Collaborator

Gamenot commented Feb 10, 2023

Is your feature request related to a problem? Please describe.
The current SMARTS engine does not allow for configuration of important features. We would like to go through parts of the engine and convert settings to

Describe the solution you'd like
Go through parts of the engine and replace areas where configuration is useful:

  • Add an engine configuration document to readthedocs
    • List out what features have been made configurable
    • List out where configuration can be found
  • Update configuration

Some examples of useful configuration are:
SMARTS_SENSOR_WORKER_COUNT,

Additional context
See the PR where the utility was added for additional context: #1828

@Gamenot Gamenot added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant