Rename smarts.core.smarts
#1849
Labels
breaking change
For issues that should be moved to a full version change.
bug
Something isn't working
Issue
Within
smarts.core
referencing thesmarts
module will give you two potential modules:<root>.smarts
and<root>.smarts.core.smarts
because the<python_path>/smarts
directory exists andsmarts.py
as a relative import for any files in the<python_path>/smarts/core
directory. These both resolve to a module and can cause ambiguous behaviour. For instancesmarts.__file__
can resolve to either location depending on the order of paths in thePYTHON_PATH
environment variable.Proposed solution
Rename
smarts.core.smarts
tosmarts.core.engine
.SMARTS
tosmarts.core.engine
smarts.core.smarts
smarts.core.smarts
imports to give a deprecation warning.smarts.core.smarts
should be removed.Additional context
Originally posted by @Gamenot in #1828 (comment)
The text was updated successfully, but these errors were encountered: