Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of non-full-rank model specifications with predict.BTm/BTabilities #7

Open
hturner opened this issue Jun 17, 2018 · 0 comments

Comments

@hturner
Copy link
Owner

hturner commented Jun 17, 2018

Relates to https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=16158

The least that should happen is for a warning to be issued, as predict.lm currently does, when "newdata" is used on a model with non-full-rank specification.

We could perhaps go still further, as Russ Lenth suggests in the above bug report, ie check the estimability of each parameter combination that's being asked for in "predict".

The package written by Russ Lenth may be an alternative to our checkEstimability function.

A simple example is this: standard Bradley-Terry model with 4 players, and match results such as
A beats B 10 times out of 40
C beats D 30 times out of 40
Here there's no information to allow prediction of, for example A vs C. But predict() gives an estimate and st error for such, and since it's nonsense there ought to be a warning accompanying them. (or ideally the result should be NA).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant