Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider contextualizing signatures #2439

Closed
DavidSchinazi opened this issue Oct 13, 2022 · 4 comments · Fixed by #2574
Closed

Consider contextualizing signatures #2439

DavidSchinazi opened this issue Oct 13, 2022 · 4 comments · Fixed by #2574

Comments

@DavidSchinazi
Copy link
Contributor

From Ilari Liusvaara on the list:

The signatures do not appear to be contextualized in any way, which is questionable. For example, one could use the same contextualization mechanism that TLS 1.3 uses (which prepends 64 spaces, a context label and NUL [one zero octet]).

@martinthomson
Copy link
Contributor

I think that I might disagree with Ilari here for this application. Key separation is probably a better model to employ here, though as soon as someone even hints that they might want to share client certificate keys and these keys then this sort of protection probably makes sense.

@mnot mnot transferred this issue from DavidSchinazi/draft-schinazi-httpbis-transport-auth Feb 24, 2023
@DavidSchinazi
Copy link
Contributor Author

Briefly mentioned this issue at IETF 116, but did not have time for questions so we asked folks who care to comment on the issue.

@DavidSchinazi
Copy link
Contributor Author

Thinking about this some more, prepending a fixed string to the nonce before signing it sounds like it would be pretty cheap and would remove a class of issues - I'm inclined to do that. I'll write up a PR.

@DavidSchinazi
Copy link
Contributor Author

OK wrote up #2574 to address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants