Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no quotes #8

Closed
eerne opened this issue Aug 16, 2013 · 7 comments
Closed

Support no quotes #8

eerne opened this issue Aug 16, 2013 · 7 comments

Comments

@eerne
Copy link

eerne commented Aug 16, 2013

No quotes like: <input type=text>
should be ok with {doctype-html5: true}

Would you accept a pull request?

@yaniswang
Copy link
Contributor

doctype-html5 is just check head doctype, if you want check quotes, please use attr-value-double-quotes

@eerne
Copy link
Author

eerne commented Aug 16, 2013

currently always fails regardless of attr-value-double-quotes

@yaniswang
Copy link
Contributor

can you show me the case how 'attr-value-double-quotes' failed?

@yaniswang
Copy link
Contributor

Yes i see, html5 can use none quotes.
I fixed this issue: https://github.com/yaniswang/HTMLHint/blob/master/test/rules/attr-value-double-quotes.spec.js
Thanks.

@eerne
Copy link
Author

eerne commented Sep 21, 2013

Thanks but why did you remove it again? :)

@yaniswang
Copy link
Contributor

HTML5 support no quotes, or double quotes, or single quote.
doctype-html5 rule is just check head doctype.
I planed to develope html5 rule, will check deeply, buy i have not time, because busy at work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants