Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html-lang-require should allow just language (not require region) #652

Closed
coliff opened this issue Jun 11, 2021 · 3 comments
Closed

html-lang-require should allow just language (not require region) #652

coliff opened this issue Jun 11, 2021 · 3 comments

Comments

@coliff
Copy link
Member

coliff commented Jun 11, 2021 •
edited
Loading

Describe the bug

HTMLHint 0.15.0 adds the html-lang-require rule. This requires both a language and a region to be set, however it is perfectly valid to use just a language on a webpage, for example <html lang="en"> should be marked as valid. The region subtag is optional.

REF:

To Reproduce
Steps to reproduce the behavior:

Run htmlhint on a webpage with <html lang="en">

Screenshots

image

cc @baleyko
@baleyko baleyko mentioned this issue Jun 11, 2021
Merged
@baleyko
Copy link
Contributor

baleyko commented Jun 11, 2021

@coliff fixes are in this PR: #655

@thedaviddias
Copy link
Member

@coliff Are we good to close this issue?

@coliff
Copy link
Member Author

coliff commented Jun 11, 2021

yep. all good now I think 👍

@coliff coliff closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thedaviddias @coliff @baleyko