feat(rules): add html-lang-require rule #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliff
reviewed
Jun 7, 2021
test/rules/html-lang-require.spec.js
Outdated
| ruleOptions[ruldId] = true | ||
|
|
||
| describe(`Rules: ${ruldId}`, () => { | ||
| it('Html tag have no a lang attribute should result in an error', () => { |
* added html-lang-require rule * add tests for html-lang-require rule
baleyko
force-pushed
the
feat/html-lang-require-rule
branch
from
68b7764
to
1d946ff
Compare
thedaviddias
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Thanks @baleyko for this, ideally the doc should also be updated but it can be done in another PR. Would you mind create another ticket to update the doc accordingly to this new rule? I let you squash and merge this ticket if you want.
thedaviddias
pushed a commit
that referenced
this pull request
Jun 10, 2021
# [0.15.0](v0.14.2...v0.15.0) (2021-06-10) ### Features * **rules:** add html-lang-require rule ([#632](#632)) ([51471a9](51471a9))
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule helps make HTML documents to correspond to the W3C requirements.
If the rule is enabled, the next example should be valid:
And the next one should not be valid: