Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly call hint queue drain #409

Merged
merged 3 commits into from
May 19, 2020
Merged

fix: correctly call hint queue drain #409

merged 3 commits into from
May 19, 2020

Conversation

Shinigami92
Copy link
Contributor

Short description of what this resolves:

The hint queue drain-function was incorrectly reassigned instead of being invoked.

Proposed changes:

  • Invoke the drain-function correctly

@Shinigami92 Shinigami92 self-assigned this May 19, 2020
@Shinigami92 Shinigami92 added the bug Functionality that does not work as intended/expected label May 19, 2020
@Shinigami92 Shinigami92 linked an issue May 19, 2020 that may be closed by this pull request
Copy link
Member

@thedaviddias thedaviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

@Shinigami92 Shinigami92 merged commit 7b63cb2 into develop May 19, 2020
@Shinigami92 Shinigami92 deleted the fix/queue-drain branch May 19, 2020 13:56
thedaviddias pushed a commit that referenced this pull request May 30, 2020
## [0.13.1-beta.1](v0.13.0...v0.13.1-beta.1) (2020-05-30)

### Bug Fixes

* add missing branches to action release ([#425](#425)) ([62c2f3c](62c2f3c))
* add missing plugins for docusaurus ([#402](#402)) ([d9ef347](d9ef347))
* correctly call hint queue drain ([#409](#409)) ([7b63cb2](7b63cb2))
* dupplicate ga ([#407](#407)) ([506f25a](506f25a))
* eslint fix ([820ff8f](820ff8f))
* fix url repo pkg ([#413](#413)) ([b7f5786](b7f5786))
* **attr-no-unnecessary-whitespace:** fix when equals symbol in value ([#405](#405)) ([fe4f3c6](fe4f3c6))
* github token ([18441f6](18441f6))
@thedaviddias
Copy link
Member

🎉 This PR is included in version 0.13.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thedaviddias thedaviddias added the released on @beta The issue was released on the beta branch label May 30, 2020
thedaviddias pushed a commit that referenced this pull request May 31, 2020
## [0.13.1](v0.13.0...v0.13.1) (2020-05-31)

### Bug Fixes

* add missing branches to action release ([#425](#425)) ([62c2f3c](62c2f3c))
* add missing plugins for docusaurus ([#402](#402)) ([d9ef347](d9ef347))
* correctly call hint queue drain ([#409](#409)) ([7b63cb2](7b63cb2))
* dupplicate ga ([#407](#407)) ([506f25a](506f25a))
* eslint fix ([820ff8f](820ff8f))
* fix url repo pkg ([#413](#413)) ([b7f5786](b7f5786))
* github token ([18441f6](18441f6))
* remove unused dependency esm ([#430](#430)) ([7e8429d](7e8429d))
* **attr-no-unnecessary-whitespace:** fix when equals symbol in value ([#405](#405)) ([fe4f3c6](fe4f3c6))
@thedaviddias
Copy link
Member

🎉 This PR is included in version 0.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality that does not work as intended/expected released on @beta The issue was released on the beta branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some formatters produces no result
2 participants