Skip to content

Commit bd8a30b

Browse files
committed
change error level
1 parent e032702 commit bd8a30b

16 files changed

+19
-10
lines changed

coverage.html

+1-1
Large diffs are not rendered by default.

lib/htmlhint.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/rules/attr-value-not-empty.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ HTMLHint.addRule({
1414
for(var i=0, l=attrs.length;i<l;i++){
1515
attr = attrs[i];
1616
if(attr.quote === '' && attr.value === ''){
17-
reporter.error('The attribute [ '+attr.name+' ] must set value.', event.line, col + attr.index, self, attr.raw);
17+
reporter.warn('The attribute [ '+attr.name+' ] must set value.', event.line, col + attr.index, self, attr.raw);
1818
}
1919
}
2020
});

src/rules/doctype-html5.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ HTMLHint.addRule({
99
var self = this;
1010
function onComment(event){
1111
if(event.long === false && event.content.toLowerCase() !== 'doctype html'){
12-
reporter.error('Doctype must be html5.', event.line, event.col, self, event.raw);
12+
reporter.warn('Doctype must be html5.', event.line, event.col, self, event.raw);
1313
}
1414
}
1515
function onTagStart(){

src/rules/head-script-disabled.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ HTMLHint.addRule({
99
var self = this;
1010
function onTagStart(event){
1111
if(event.tagName.toLowerCase() === 'script'){
12-
reporter.error('The script tag can not be used in head.', event.line, event.col, self, event.raw);
12+
reporter.warn('The script tag can not be used in head.', event.line, event.col, self, event.raw);
1313
}
1414
}
1515
function onTagEnd(event){

src/rules/id-class-value.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ HTMLHint.addRule({
3838
attr = attrs[i];
3939
if(attr.name.toLowerCase() === 'id'){
4040
if(regId.test(attr.value) === false){
41-
reporter.error(message, event.line, col + attr.index, self, attr.raw);
41+
reporter.warn(message, event.line, col + attr.index, self, attr.raw);
4242
}
4343
}
4444
if(attr.name.toLowerCase() === 'class'){
4545
var arrClass = attr.value.split(/\s+/g), classValue;
4646
for(var j=0, l2=arrClass.length;j<l2;j++){
4747
classValue = arrClass[j];
4848
if(classValue && regId.test(classValue) === false){
49-
reporter.error(message, event.line, col + attr.index, self, classValue);
49+
reporter.warn(message, event.line, col + attr.index, self, classValue);
5050
}
5151
}
5252
}

src/rules/img-alt-require.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ HTMLHint.addRule({
1818
}
1919
}
2020
if(haveAlt === false){
21-
reporter.error('Alt of img tag must be set value.', event.line, event.col, self, event.raw);
21+
reporter.warn('Alt of img tag must be set value.', event.line, event.col, self, event.raw);
2222
}
2323
}
2424
});

src/rules/style-disabled.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ HTMLHint.addRule({
99
var self = this;
1010
parser.addListener('tagstart', function(event){
1111
if(event.tagName.toLowerCase() === 'style'){
12-
reporter.error('Style tag can not be use.', event.line, event.col, self, event.raw);
12+
reporter.warn('Style tag can not be use.', event.line, event.col, self, event.raw);
1313
}
1414
});
1515
}

src/rules/tag-self-close.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ HTMLHint.addRule({
1212
var tagName = event.tagName.toLowerCase();
1313
if(mapEmptyTags[tagName] !== undefined){
1414
if(!event.close){
15-
reporter.error('The empty tag must closed by self.', event.line, event.col, self, event.raw);
15+
reporter.warn('The empty tag must closed by self.', event.line, event.col, self, event.raw);
1616
}
1717
}
1818
});

test/rules/attr-value-not-empty.spec.js

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ describe('Rules: attr-value-not-empty', function(){
1616
expect(messages[0].rule.id).to.be('attr-value-not-empty');
1717
expect(messages[0].line).to.be(1);
1818
expect(messages[0].col).to.be(7);
19+
expect(messages[0].type).to.be('warning');
1920
});
2021

2122
it('Attribute value closed by quote but no value should not result in an error', function(){

test/rules/doctype-html5.spec.js

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ describe('Rules: doctype-html5', function(){
1616
expect(messages[0].rule.id).to.be('doctype-html5');
1717
expect(messages[0].line).to.be(1);
1818
expect(messages[0].col).to.be(1);
19+
expect(messages[0].type).to.be('warning');
1920
});
2021

2122
it('Doctype html5 should not result in an error', function(){

test/rules/head-script-disabled.spec.js

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ describe('Rules: head-script-disabled', function(){
1616
expect(messages[0].rule.id).to.be('head-script-disabled');
1717
expect(messages[0].line).to.be(1);
1818
expect(messages[0].col).to.be(7);
19+
expect(messages[0].type).to.be('warning');
1920
});
2021

2122
it('Internal Script in head should result in an error', function(){

test/rules/id-class-value.spec.js

+2
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,11 @@ describe('Rules: id-class-value', function(){
1616
expect(messages[0].rule.id).to.be('id-class-value');
1717
expect(messages[0].line).to.be(1);
1818
expect(messages[0].col).to.be(5);
19+
expect(messages[0].type).to.be('warning');
1920
expect(messages[1].rule.id).to.be('id-class-value');
2021
expect(messages[1].line).to.be(1);
2122
expect(messages[1].col).to.be(17);
23+
expect(messages[1].type).to.be('warning');
2224
});
2325

2426
it('Id and class value be lower case and split by underline should not result in an error', function(){

test/rules/img-alt-require.spec.js

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ describe('Rules: img-alt-require', function(){
1616
expect(messages[0].rule.id).to.be('img-alt-require');
1717
expect(messages[0].line).to.be(1);
1818
expect(messages[0].col).to.be(1);
19+
expect(messages[0].type).to.be('warning');
1920
});
2021

2122
it('Img tag have alt attr should not result in an error', function(){

test/rules/style-disabled.spec.js

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ describe('Rules: style-disabled', function(){
1616
expect(messages[0].rule.id).to.be('style-disabled');
1717
expect(messages[0].line).to.be(1);
1818
expect(messages[0].col).to.be(7);
19+
expect(messages[0].type).to.be('warning');
1920
});
2021

2122
it('Stylesheet link should not result in an error', function(){

test/rules/tag-self-close.spec.js

+2
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,11 @@ describe('Rules: tag-self-close', function(){
1616
expect(messages[0].rule.id).to.be('tag-self-close');
1717
expect(messages[0].line).to.be(1);
1818
expect(messages[0].col).to.be(1);
19+
expect(messages[0].type).to.be('warning');
1920
expect(messages[1].rule.id).to.be('tag-self-close');
2021
expect(messages[1].line).to.be(1);
2122
expect(messages[1].col).to.be(5);
23+
expect(messages[1].type).to.be('warning');
2224
});
2325

2426
it('Closed empty tag should not result in an error', function(){

0 commit comments

Comments
 (0)