Make spec-char-escape more accurate

yaniswang · yaniswang · commit b9eae3e12310 · 2013-02-27T11:00:05.000+08:00
diff --git a/lib/htmlhint.js b/lib/htmlhint.js
diff --git a/src/rules/spec-char-escape.js b/src/rules/spec-char-escape.js
@@ -8,8 +8,9 @@ HTMLHint.addRule({
     init: function(parser, reporter){
         var self = this;
         parser.addListener('text', function(event){
-            if(/[<>]/.test(event.raw) === true){
-                reporter.error('Special characters must be escaped.', event.line, event.col, self, event.raw);
+            var match = event.raw.match(/[<>]/);
+            if(match !== null){
+                reporter.error('Special characters must be escaped [ '+match[0]+' ].', event.line, event.col + match.index, self, event.raw);
             }
         });
     }
diff --git a/tests/test.js b/tests/test.js
@@ -1,6 +1,6 @@
 //本文件临时开发测试用，近期开始写完整的单测
 var HTMLHint = require('../lib/htmlhint').HTMLHint;
-var text = '\r\n\r\na<!DOCTYPE html><html lanG="en" b=\'1\' c=2><heaD\r\na>a<\r\nb\r\nc<meta content="text/html; charset=utf-8" http-equiv="Content-Type" /><script></script></head><body class="classA b c d"><img src=""><br><ul id="abA"><li><span></ul></aaa><style>a{}</style>abc<script>var aaa;</script></body></html>';
+var text = '\r\n\r\na<!DOCTYPE html><html lanG="en" b=\'1\' c=2><heaD\r\na>ab<\r\nb\r\nc<meta content="text/html; charset=utf-8" http-equiv="Content-Type" /><script></script></head><body class="classA b c d"><img src=""><br><ul id="abA"><li><span></ul></aaa><style>a{}</style>abc<script>var aaa;</script></body></html>';
 // text = '';
 var messages = HTMLHint.verify(text, {
     // 'img-alt-require': true,
@@ -11,9 +11,9 @@ var messages = HTMLHint.verify(text, {
     // 'attr-lower-case': true,
     // 'attr-value-double-quotes': true,
     // 'attr-value-empty': true,
-    // 'spec-char-escape': true,
+    'spec-char-escape': true,
     // 'style-disabled': true,
-    'tag-pair': true,
+    // 'tag-pair': true,
     // 'tag-self-close': true,
     // 'id-class-value': {
     //         'regId': /^(J-)?[a-z\d]+(-[a-z\d]+)*$/,

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,9 @@ HTMLHint.addRule({`
`8`	`8`	`init: function(parser, reporter){`
`9`	`9`	`var self = this;`
`10`	`10`	`parser.addListener('text', function(event){`
`11`		`- if(/[<>]/.test(event.raw) === true){`
`12`		`- reporter.error('Special characters must be escaped.', event.line, event.col, self, event.raw);`
	`11`	`+ var match = event.raw.match(/[<>]/);`
	`12`	`+ if(match !== null){`
	`13`	`+ reporter.error('Special characters must be escaped [ '+match[0]+' ].', event.line, event.col + match.index, self, event.raw);`
`13`	`14`	`}`
`14`	`15`	`});`
`15`	`16`	`}`