Skip to content

Commit 88d00ab

Browse files
committed
fix rule: attr-value-double-quotes
1 parent 6088fb3 commit 88d00ab

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

coverage.html

+1-1
Large diffs are not rendered by default.

lib/htmlhint.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/rules/attr-value-double-quotes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ HTMLHint.addRule({
1313
col = event.col + event.tagName.length + 1;
1414
for(var i=0, l=attrs.length;i<l;i++){
1515
attr = attrs[i];
16-
if(attr.quote !== '' && attr.quote !== '"'){
16+
if(attr.quote !== '"' && (attr.value !== '' || (attr.value === attr.quote === ''))){
1717
reporter.error('The value of attribute [ '+attr.name+' ] must closed by double quotes.', event.line, col + attr.index, self, attr.raw);
1818
}
1919
}

test/rules/attr-value-double-quotes.spec.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,19 @@ var HTMLHint = require("../../index").HTMLHint;
1010
describe('Rules: attr-value-double-quotes', function(){
1111

1212
it('Attribute value closed by single quotes should result in an error', function(){
13-
var code = '<a href=\'abc\'>';
13+
var code = '<a href=\'abc\' title=abc>';
1414
var messages = HTMLHint.verify(code, {'attr-value-double-quotes': true});
15-
expect(messages.length).to.be(1);
15+
expect(messages.length).to.be(2);
1616
expect(messages[0].rule.id).to.be('attr-value-double-quotes');
1717
expect(messages[0].line).to.be(1);
1818
expect(messages[0].col).to.be(3);
19+
expect(messages[1].rule.id).to.be('attr-value-double-quotes');
20+
expect(messages[1].line).to.be(1);
21+
expect(messages[1].col).to.be(14);
1922
});
2023

2124
it('Attribute value no closed should not result in an error', function(){
22-
var code = '<a href=abc>';
25+
var code = '<input type="button" disabled>';
2326
var messages = HTMLHint.verify(code, {'attr-value-double-quotes': true});
2427
expect(messages.length).to.be(0);
2528
});

0 commit comments

Comments
 (0)