diff --git a/coverage.html b/coverage.html index c5bedf1d2..f477cbca6 100644 --- a/coverage.html +++ b/coverage.html @@ -338,4 +338,4 @@ code .string { color: #5890AD } code .keyword { color: #8A6343 } code .number { color: #2F6FAD } -

Coverage

98%
412
406
6

htmlhint.js

98%
412
406
6
LineHitsSource
1/**
2 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
3 * MIT Licensed
4 */
51var HTMLHint = (function (undefined) {
6
71 var HTMLHint = {};
8
91 HTMLHint.version = '@VERSION';
10
111 HTMLHint.rules = {};
12
13 //默认配置
141 HTMLHint.defaultRuleset = {
15 'tagname-lowercase': true,
16 'attr-lowercase': true,
17 'attr-value-double-quotes': true,
18 'doctype-first': true,
19 'tag-pair': true,
20 'spec-char-escape': true,
21 'id-unique': true,
22 'src-not-empty': true,
23 'attr-no-duplication': true
24 };
25
261 HTMLHint.addRule = function(rule){
2721 HTMLHint.rules[rule.id] = rule;
28 };
29
301 HTMLHint.verify = function(html, newRuleset){
3180 var id;
3280 var ruleset;
33 // parse inline ruleset
3480 html = html.replace(/^\s*<!--\s*htmlhint\s+([^\r\n]+?)\s*-->/i, function(all, strRuleset){
352 ruleset = {};
362 strRuleset.replace(/(?:^|,)\s*([^:]+)\s*:\s*([^,\s]+)/g, function(all, key, value){
372 if(value === 'false'){
380 value = false;
39 }
402 else if(value === 'true'){
412 value = true;
42 }
432 ruleset[key] = value;
44 });
452 return '';
46 });
4780 if(newRuleset !== undefined){
4877 ruleset = ruleset || {};
4977 for (id in newRuleset){
5077 ruleset[id] = newRuleset[id];
51 }
52 }
5380 if(ruleset === undefined){
542 ruleset = HTMLHint.defaultRuleset;
55 }
56
5780 var parser = new HTMLParser();
5880 var reporter = new HTMLHint.Reporter(html.split(/\r?\n/), ruleset);
59
6080 var rules = HTMLHint.rules,
61 rule;
6280 for (id in ruleset){
6396 rule = rules[id];
6496 if (rule !== undefined && ruleset[id] !== false){
6594 rule.init(parser, reporter, ruleset[id]);
66 }
67 }
68
6980 parser.parse(html);
70
7180 return reporter.messages;
72 };
73
741 return HTMLHint;
75
76})();
77
781if (typeof exports === 'object' && exports){
791 exports.HTMLHint = HTMLHint;
80}
81/**
82 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
83 * MIT Licensed
84 */
851(function(HTMLHint, undefined){
86
871 var Reporter = function(){
8880 var self = this;
8980 self._init.apply(self,arguments);
90 };
91
921 Reporter.prototype = {
93 _init: function(lines, ruleset){
9480 var self = this;
9580 self.lines = lines;
9680 self.ruleset = ruleset;
9780 self.messages = [];
98 },
99 //错误
100 error: function(message, line, col, rule, raw){
10147 this.report('error', message, line, col, rule, raw);
102 },
103 //警告
104 warn: function(message, line, col, rule, raw){
10544 this.report('warning', message, line, col, rule, raw);
106 },
107 //信息
108 info: function(message, line, col, rule, raw){
1090 this.report('info', message, line, col, rule, raw);
110 },
111 //报告
112 report: function(type, message, line, col, rule, raw){
11391 var self = this;
11491 self.messages.push({
115 type: type,
116 message: message,
117 raw: raw,
118 evidence: self.lines[line-1],
119 line: line,
120 col: col,
121 rule: {
122 id: rule.id,
123 description: rule.description,
124 link: 'https://github.com/yaniswang/HTMLHint/wiki/' + rule.id
125 }
126 });
127 }
128 };
129
1301 HTMLHint.Reporter = Reporter;
131
132})(HTMLHint);
133/**
134 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
135 * MIT Licensed
136 */
1371var HTMLParser = (function(undefined){
138
1391 var HTMLParser = function(){
140105 var self = this;
141105 self._init.apply(self,arguments);
142 };
143
1441 HTMLParser.prototype = {
145 _init: function(){
146105 var self = this;
147105 self._listeners = {};
148105 self._mapCdataTags = self.makeMap("script,style");
149105 self._arrBlocks = [];
150 },
151
152 makeMap: function(str){
153112 var obj = {}, items = str.split(",");
154112 for ( var i = 0; i < items.length; i++ ){
155308 obj[ items[i] ] = true;
156 }
157112 return obj;
158 },
159
160 // parse html code
161 parse: function(html){
162
163105 var self = this,
164 mapCdataTags = self._mapCdataTags;
165
166105 var regTag=/<(?:\/([^\s>]+)\s*|!--([\s\S]*?)--|!([^>]*?)|([\w\-:]+)((?:\s+[\w\-:]+(?:\s*=\s*(?:"[^"]*"|'[^']*'|[^\s"']+))?)*?)\s*(\/?))>/g,
167 regAttr = /\s*([\w\-:]+)(?:\s*=\s*(?:(")([^"]*)"|(')([^']*)'|([^\s"']+)))?/g,
168 regLine = /\r?\n/g;
169
170105 var match, matchIndex, lastIndex = 0, tagName, arrAttrs, tagCDATA, attrsCDATA, arrCDATA, lastCDATAIndex = 0, text;
171105 var lastLineIndex = 0, line = 1;
172105 var arrBlocks = self._arrBlocks;
173
174105 self.fire('start', {
175 pos: 0,
176 line: 1,
177 col: 1
178 });
179
180105 while((match = regTag.exec(html))){
181252 matchIndex = match.index;
182252 if(matchIndex > lastIndex){//保存前面的文本或者CDATA
18376 text = html.substring(lastIndex, matchIndex);
18476 if(tagCDATA){
18510 arrCDATA.push(text);
186 }
187 else{//文本
18866 saveBlock('text', text, lastIndex);
189 }
190 }
191252 lastIndex = regTag.lastIndex;
192
193252 if((tagName = match[1])){
19489 if(tagCDATA && tagName === tagCDATA){//结束标签前输出CDATA
19515 text = arrCDATA.join('');
19615 saveBlock('cdata', text, lastCDATAIndex, {
197 'tagName': tagCDATA,
198 'attrs': attrsCDATA
199 });
20015 tagCDATA = null;
20115 attrsCDATA = null;
20215 arrCDATA = null;
203 }
20489 if(!tagCDATA){
205 //标签结束
20688 saveBlock('tagend', match[0], matchIndex, {
207 'tagName': tagName
208 });
20988 continue;
210 }
211 }
212
213164 if(tagCDATA){
2141 arrCDATA.push(match[0]);
215 }
216 else{
217163 if((tagName = match[4])){//标签开始
218150 arrAttrs = [];
219150 var attrs = match[5],
220 attrMatch,
221 attrMatchCount = 0;
222150 while((attrMatch = regAttr.exec(attrs))){
223143 var name = attrMatch[1],
224 quote = attrMatch[2] ? attrMatch[2] :
225 attrMatch[4] ? attrMatch[4] : '',
226 value = attrMatch[3] ? attrMatch[3] :
227 attrMatch[5] ? attrMatch[5] :
228 attrMatch[6] ? attrMatch[6] : '';
229143 arrAttrs.push({'name': name, 'value': value, 'quote': quote, 'index': attrMatch.index, 'raw': attrMatch[0]});
230143 attrMatchCount += attrMatch[0].length;
231 }
232150 if(attrMatchCount === attrs.length){
233150 saveBlock('tagstart', match[0], matchIndex, {
234 'tagName': tagName,
235 'attrs': arrAttrs,
236 'close': match[6]
237 });
238150 if(mapCdataTags[tagName]){
23915 tagCDATA = tagName;
24015 attrsCDATA = arrAttrs.concat();
24115 arrCDATA = [];
24215 lastCDATAIndex = lastIndex;
243 }
244 }
245 else{//如果出现漏匹配，则把当前内容匹配为text
2460 saveBlock('text', match[0], matchIndex);
247 }
248 }
24913 else if(match[2] || match[3]){//注释标签
25013 saveBlock('comment', match[0], matchIndex, {
251 'content': match[2] || match[3],
252 'long': match[2]?true:false
253 });
254 }
255 }
256 }
257
258105 if(html.length > lastIndex){
259 //结尾文本
26013 text = html.substring(lastIndex, html.length);
26113 saveBlock('text', text, lastIndex);
262 }
263
264105 self.fire('end', {
265 pos: lastIndex,
266 line: line,
267 col: lastIndex - lastLineIndex + 1
268 });
269
270 //存储区块
271105 function saveBlock(type, raw, pos, data){
272345 var col = pos - lastLineIndex + 1;
273345 if(data === undefined){
27479 data = {};
275 }
276345 data.raw = raw;
277345 data.pos = pos;
278345 data.line = line;
279345 data.col = col;
280345 arrBlocks.push(data);
281345 self.fire(type, data);
282345 var lineMatch;
283345 while((lineMatch = regLine.exec(raw))){
28422 line ++;
28522 lastLineIndex = pos + regLine.lastIndex;
286 }
287 }
288
289 },
290
291 // add event
292 addListener: function(types, listener){
293134 var _listeners = this._listeners;
294134 var arrTypes = types.split(/[,\s]/), type;
295134 for(var i=0, l = arrTypes.length;i<l;i++){
296138 type = arrTypes[i];
297138 if (_listeners[type] === undefined){
298124 _listeners[type] = [];
299 }
300138 _listeners[type].push(listener);
301 }
302 },
303
304 // fire event
305 fire: function(type, data){
306555 if (data === undefined){
3070 data = {};
308 }
309555 data.type = type;
310555 var self = this,
311 listeners = [],
312 listenersType = self._listeners[type],
313 listenersAll = self._listeners['all'];
314555 if (listenersType !== undefined){
315156 listeners = listeners.concat(listenersType);
316 }
317555 if (listenersAll !== undefined){
318130 listeners = listeners.concat(listenersAll);
319 }
320555 for (var i = 0, l = listeners.length; i < l; i++){
321299 listeners[i].call(self, data);
322 }
323 },
324
325 // remove event
326 removeListener: function(type, listener){
32714 var listenersType = this._listeners[type];
32814 if(listenersType !== undefined){
32912 for (var i = 0, l = listenersType.length; i < l; i++){
3309 if (listenersType[i] === listener){
3319 listenersType.splice(i, 1);
3329 break;
333 }
334 }
335 }
336 },
337
338 //fix pos if event.raw have \n
339 fixPos: function(event, index){
3407 var text = event.raw.substr(0, index);
3417 var arrLines = text.split(/\r?\n/),
342 lineCount = arrLines.length - 1,
343 line = event.line, col;
3447 if(lineCount > 0){
3452 line += lineCount;
3462 col = arrLines[lineCount].length + 1;
347 }
348 else{
3495 col = event.col + index;
350 }
3517 return {
352 line: line,
353 col: col
354 };
355 },
356
357 // covert array type of attrs to map
358 getMapAttrs: function(arrAttrs){
3596 var mapAttrs = {},
360 attr;
3616 for(var i=0,l=arrAttrs.length;i<l;i++){
3626 attr = arrAttrs[i];
3636 mapAttrs[attr.name] = attr.value;
364 }
3656 return mapAttrs;
366 }
367 };
368
3691 return HTMLParser;
370
371})();
372
3731if (typeof exports === 'object' && exports){
3741 exports.HTMLParser = HTMLParser;
375}
376/**
377 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
378 * MIT Licensed
379 */
3801HTMLHint.addRule({
381 id: 'attr-lowercase',
382 description: 'Attribute name must be lowercase.',
383 init: function(parser, reporter){
3844 var self = this;
3854 parser.addListener('tagstart', function(event){
3866 var attrs = event.attrs,
387 attr,
388 col = event.col + event.tagName.length + 1;
3896 for(var i=0, l=attrs.length;i<l;i++){
3909 attr = attrs[i];
3919 var attrName = attr.name;
3929 if(attrName !== attrName.toLowerCase()){
3933 reporter.error('Attribute name [ '+attrName+' ] must be lower case.', event.line, col + attr.index, self, attr.raw);
394 }
395 }
396 });
397 }
398});
399/**
400 * Copyright (c) 2014, Yanis Wang <yanis.wang@gmail.com>
401 * MIT Licensed
402 */
4031HTMLHint.addRule({
404 id: 'attr-no-duplication',
405 description: 'Attribute name can not been duplication.',
406 init: function(parser, reporter){
4074 var self = this;
4084 parser.addListener('tagstart', function(event){
4096 var attrs = event.attrs;
4106 var attr;
4116 var attrName;
4126 var col = event.col + event.tagName.length + 1;
413
4146 var mapAttrName = {};
4156 for(var i=0, l=attrs.length;i<l;i++){
41610 attr = attrs[i];
41710 attrName = attr.name;
41810 if(mapAttrName[attrName] === true){
4192 reporter.error('The name of attribute [ '+attr.name+' ] been duplication.', event.line, col + attr.index, self, attr.raw);
420 }
42110 mapAttrName[attrName] = true;
422 }
423 });
424 }
425});
426/**
427 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
428 * MIT Licensed
429 */
4301HTMLHint.addRule({
431 id: 'attr-value-double-quotes',
432 description: 'Attribute value must closed by double quotes.',
433 init: function(parser, reporter){
4344 var self = this;
4354 parser.addListener('tagstart', function(event){
4366 var attrs = event.attrs,
437 attr,
438 col = event.col + event.tagName.length + 1;
4396 for(var i=0, l=attrs.length;i<l;i++){
44013 attr = attrs[i];
44113 if((attr.value !== '' && attr.quote !== '"') ||
442 (attr.value === '' && attr.quote === "'")){
4434 reporter.error('The value of attribute [ '+attr.name+' ] must closed by double quotes.', event.line, col + attr.index, self, attr.raw);
444 }
445 }
446 });
447 }
448});
449/**
450 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
451 * MIT Licensed
452 */
4531HTMLHint.addRule({
454 id: 'attr-value-not-empty',
455 description: 'Attribute must set value.',
456 init: function(parser, reporter){
4573 var self = this;
4583 parser.addListener('tagstart', function(event){
4593 var attrs = event.attrs,
460 attr,
461 col = event.col + event.tagName.length + 1;
4623 for(var i=0, l=attrs.length;i<l;i++){
4633 attr = attrs[i];
4643 if(attr.quote === '' && attr.value === ''){
4651 reporter.warn('The attribute [ '+attr.name+' ] must set value.', event.line, col + attr.index, self, attr.raw);
466 }
467 }
468 });
469 }
470});
471/**
472 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
473 * MIT Licensed
474 */
4751HTMLHint.addRule({
476 id: 'csslint',
477 description: 'Scan css with csslint.',
478 init: function(parser, reporter, options){
4791 var self = this;
4801 parser.addListener('cdata', function(event){
4811 if(event.tagName.toLowerCase() === 'style'){
482
4831 var cssVerify;
484
4851 if(typeof exports === 'object' && require){
4861 cssVerify = require("csslint").CSSLint.verify;
487 }
488 else{
4890 cssVerify = CSSLint.verify;
490 }
491
4921 if(options !== undefined){
4931 var styleLine = event.line - 1,
494 styleCol = event.col - 1;
4951 try{
4961 var messages = cssVerify(event.raw, options).messages;
4971 messages.forEach(function(error){
4982 var line = error.line;
4992 reporter[error.type==='warning'?'warn':'error']('['+error.rule.id+'] '+error.message, styleLine + line, (line === 1 ? styleCol : 0) + error.col, self, error.evidence);
500 });
501 }
502 catch(e){}
503 }
504
505 }
506 });
507 }
508});
509/**
510 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
511 * MIT Licensed
512 */
5131HTMLHint.addRule({
514 id: 'doctype-first',
515 description: 'Doctype must be first.',
516 init: function(parser, reporter){
5174 var self = this;
5184 var allEvent = function(event){
5198 if(event.type === 'start' || (event.type === 'text' && /^\s*$/.test(event.raw))){
5204 return;
521 }
5224 if((event.type !== 'comment' && event.long === false) || /^DOCTYPE\s+/i.test(event.content) === false){
5233 reporter.error('Doctype must be first.', event.line, event.col, self, event.raw);
524 }
5254 parser.removeListener('all', allEvent);
526 };
5274 parser.addListener('all', allEvent);
528 }
529});
530/**
531 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
532 * MIT Licensed
533 */
5341HTMLHint.addRule({
535 id: 'doctype-html5',
536 description: 'Doctype must be html5.',
537 init: function(parser, reporter){
5382 var self = this;
5392 function onComment(event){
5409 if(event.long === false && event.content.toLowerCase() !== 'doctype html'){
5411 reporter.warn('Doctype must be html5.', event.line, event.col, self, event.raw);
542 }
543 }
5442 function onTagStart(){
5452 parser.removeListener('comment', onComment);
5462 parser.removeListener('tagstart', onTagStart);
547 }
5482 parser.addListener('all', onComment);
5492 parser.addListener('tagstart', onTagStart);
550 }
551});
552/**
553 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
554 * MIT Licensed
555 */
5561HTMLHint.addRule({
557 id: 'head-script-disabled',
558 description: 'The script tag can not be used in head.',
559 init: function(parser, reporter){
5603 var self = this;
5613 function onTagStart(event){
5625 if(event.tagName.toLowerCase() === 'script'){
5632 reporter.warn('The script tag can not be used in head.', event.line, event.col, self, event.raw);
564 }
565 }
5663 function onTagEnd(event){
5677 if(event.tagName.toLowerCase() === 'head'){
5683 parser.removeListener('tagstart', onTagStart);
5693 parser.removeListener('tagstart', onTagEnd);
570 }
571 }
5723 parser.addListener('tagstart', onTagStart);
5733 parser.addListener('tagend', onTagEnd);
574 }
575});
576/**
577 * Copyright (c) 2014, Yanis Wang <yanis.wang@gmail.com>
578 * MIT Licensed
579 */
5801HTMLHint.addRule({
581 id: 'href-abs-or-rel',
582 description: 'Href must be absolute or relative.',
583 init: function(parser, reporter, options){
5844 var self = this;
585
5864 var hrefMode = options === 'abs' ? 'absolute' : 'relative';
587
5884 parser.addListener('tagstart', function(event){
58916 var attrs = event.attrs;
59016 var attr;
59116 var col = event.col + event.tagName.length + 1;
592
59316 for(var i=0, l=attrs.length;i<l;i++){
59416 attr = attrs[i];
59516 if(attr.name === 'href'){
59616 if((hrefMode === 'absolute' && /^\w+?:/.test(attr.value) === false) ||
597 (hrefMode === 'relative' && /^https?:\/\//.test(attr.value) === true)){
5984 reporter.error('The value of href [ '+attr.value+' ] must be '+hrefMode+'.', event.line, col + attr.index, self, attr.raw);
599 }
60016 break;
601 }
602 }
603 });
604 }
605});
606/**
607 * Copyright (c) 2014, Yanis Wang <yanis.wang@gmail.com>
608 * MIT Licensed
609 */
6101HTMLHint.addRule({
611 id: 'id-class-ad-disabled',
612 description: 'Id and class can not use ad keyword, it will blocked by adblock software.',
613 init: function(parser, reporter){
61417 var self = this;
61517 parser.addListener('tagstart', function(event){
61617 var attrs = event.attrs;
61717 var attr;
61817 var attrName;
61917 var col = event.col + event.tagName.length + 1;
620
62117 for(var i=0, l=attrs.length;i<l;i++){
62220 attr = attrs[i];
62320 attrName = attr.name;
62420 if(/^(id|class)$/i.test(attrName)){
62520 if(/(^|[-\_])ad([-\_]|$)/i.test(attr.value)){
62614 reporter.warn('The value of '+attrName+' can not use ad keyword.', event.line, col + attr.index, self, attr.raw);
627 }
628 }
629 }
630 });
631 }
632});
633/**
634 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
635 * MIT Licensed
636 */
6371HTMLHint.addRule({
638 id: 'id-class-value',
639 description: 'Id and class value must meet some rules.',
640 init: function(parser, reporter, options){
6418 var self = this;
6428 var arrRules = {
643 'underline': {
644 'regId': /^[a-z\d]+(_[a-z\d]+)*$/,
645 'message': 'Id and class value must lower case and split by underline.'
646 },
647 'dash': {
648 'regId': /^[a-z\d]+(-[a-z\d]+)*$/,
649 'message': 'Id and class value must lower case and split by dash.'
650 },
651 'hump': {
652 'regId': /^[a-z][a-zA-Z\d]*([A-Z][a-zA-Z\d]*)*$/,
653 'message': 'Id and class value must meet hump style.'
654 }
655 }, rule;
6568 if(typeof options === 'string'){
6576 rule = arrRules[options];
658 }
659 else{
6602 rule = options;
661 }
6628 if(rule && rule.regId){
6638 var regId = rule.regId,
664 message = rule.message;
6658 parser.addListener('tagstart', function(event){
6668 var attrs = event.attrs,
667 attr,
668 col = event.col + event.tagName.length + 1;
6698 for(var i=0, l1=attrs.length;i<l1;i++){
67016 attr = attrs[i];
67116 if(attr.name.toLowerCase() === 'id'){
6728 if(regId.test(attr.value) === false){
6734 reporter.warn(message, event.line, col + attr.index, self, attr.raw);
674 }
675 }
67616 if(attr.name.toLowerCase() === 'class'){
6778 var arrClass = attr.value.split(/\s+/g), classValue;
6788 for(var j=0, l2=arrClass.length;j<l2;j++){
6798 classValue = arrClass[j];
6808 if(classValue && regId.test(classValue) === false){
6814 reporter.warn(message, event.line, col + attr.index, self, classValue);
682 }
683 }
684 }
685 }
686 });
687 }
688 }
689});
690/**
691 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
692 * MIT Licensed
693 */
6941HTMLHint.addRule({
695 id: 'id-unique',
696 description: 'Id must be unique.',
697 init: function(parser, reporter){
6984 var self = this;
6994 var mapIdCount = {};
7004 parser.addListener('tagstart', function(event){
7018 var attrs = event.attrs,
702 attr,
703 id,
704 col = event.col + event.tagName.length + 1;
7058 for(var i=0, l=attrs.length;i<l;i++){
70611 attr = attrs[i];
70711 if(attr.name.toLowerCase() === 'id'){
7086 id = attr.value;
7096 if(id){
7106 if(mapIdCount[id] === undefined){
7114 mapIdCount[id] = 1;
712 }
713 else{
7142 mapIdCount[id] ++;
715 }
7166 if(mapIdCount[id] > 1){
7172 reporter.error('Id redefinition of [ '+id+' ].', event.line, col + attr.index, self, attr.raw);
718 }
719 }
7206 break;
721 }
722 }
723 });
724 }
725});
726/**
727 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
728 * MIT Licensed
729 */
7301HTMLHint.addRule({
731 id: 'img-alt-require',
732 description: 'Alt of img tag must be set value.',
733 init: function(parser, reporter){
7344 var self = this;
7354 parser.addListener('tagstart', function(event){
7364 if(event.tagName.toLowerCase() === 'img'){
7374 var attrs = event.attrs;
7384 var haveAlt = false;
7394 for(var i=0, l=attrs.length;i<l;i++){
7409 if(attrs[i].name.toLowerCase() === 'alt'){
7412 haveAlt = true;
7422 break;
743 }
744 }
7454 if(haveAlt === false){
7462 reporter.warn('Alt of img tag must be set value.', event.line, event.col, self, event.raw);
747 }
748 }
749 });
750 }
751});
752/**
753 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
754 * MIT Licensed
755 */
7561HTMLHint.addRule({
757 id: 'jshint',
758 description: 'Scan script with jshint.',
759 init: function(parser, reporter, options){
7604 var self = this;
7614 parser.addListener('cdata', function(event){
7624 if(event.tagName.toLowerCase() === 'script'){
763
7644 var mapAttrs = parser.getMapAttrs(event.attrs),
765 type = mapAttrs.type;
766
767 // Only scan internal javascript
7684 if(mapAttrs.src !== undefined || (type && /^(text\/javascript)$/i.test(type) === false)){
7692 return;
770 }
771
7722 var jsVerify;
773
7742 if(typeof exports === 'object' && require){
7752 jsVerify = require('jshint').JSHINT;
776 }
777 else{
7780 jsVerify = JSHINT;
779 }
780
7812 if(options !== undefined){
7822 var styleLine = event.line - 1,
783 styleCol = event.col - 1;
7842 var code = event.raw.replace(/\t/g,' ');
7852 try{
7862 var status = jsVerify(code, options);
7872 if(status === false){
7882 jsVerify.errors.forEach(function(error){
7898 var line = error.line;
7908 reporter.warn(error.reason, styleLine + line, (line === 1 ? styleCol : 0) + error.character, self, error.evidence);
791 });
792 }
793 }
794 catch(e){}
795 }
796
797 }
798 });
799 }
800});
801/**
802 * Copyright (c) 2014, Yanis Wang <yanis.wang@gmail.com>
803 * MIT Licensed
804 */
8051HTMLHint.addRule({
806 id: 'space-tab-mixed-disabled',
807 description: 'Spaces and tabs can not mixed in front of line.',
808 init: function(parser, reporter){
8096 var self = this;
8106 parser.addListener('text', function(event){
81112 var raw = event.raw;
81212 var reMixed = /(^|\r?\n)( +\t|\t+ )/g;
81312 var match;
81412 while((match = reMixed.exec(raw))){
8153 var fixedPos = parser.fixPos(event, match.index + match[1].length);
8163 reporter.warn('Mixed spaces and tabs in front of line.', fixedPos.line, 1, self, event.raw);
817 }
818 });
819 }
820});
821/**
822 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
823 * MIT Licensed
824 */
8251HTMLHint.addRule({
826 id: 'spec-char-escape',
827 description: 'Special characters must be escaped.',
828 init: function(parser, reporter){
8294 var self = this;
8304 parser.addListener('text', function(event){
8314 var raw = event.raw,
832 reSpecChar = /[<>]/g,
833 match;
8344 while((match = reSpecChar.exec(raw))){
8354 var fixedPos = parser.fixPos(event, match.index);
8364 reporter.error('Special characters must be escaped : [ '+match[0]+' ].', fixedPos.line, fixedPos.col, self, event.raw);
837 }
838 });
839 }
840});
841/**
842 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
843 * MIT Licensed
844 */
8451HTMLHint.addRule({
846 id: 'src-not-empty',
847 description: 'Src of img(script,link) must set value.',
848 init: function(parser, reporter){
8495 var self = this;
8505 parser.addListener('tagstart', function(event){
85132 var tagName = event.tagName,
852 attrs = event.attrs,
853 attr,
854 col = event.col + tagName.length + 1;
85532 for(var i=0, l=attrs.length;i<l;i++){
85636 attr = attrs[i];
85736 if(((/^(img|script|embed|bgsound|iframe)$/.test(tagName) === true && attr.name === 'src') ||
858 (tagName === 'link' && attr.name === 'href') ||
859 (tagName === 'object' && attr.name === 'data')) &&
860 attr.value === ''){
86115 reporter.error('[ '+attr.name + '] of [ '+tagName+' ] must set value.', event.line, col + attr.index, self, attr.raw);
862 }
863 }
864 });
865 }
866});
867/**
868 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
869 * MIT Licensed
870 */
8711HTMLHint.addRule({
872 id: 'style-disabled',
873 description: 'Style tag can not be use.',
874 init: function(parser, reporter){
8752 var self = this;
8762 parser.addListener('tagstart', function(event){
8774 if(event.tagName.toLowerCase() === 'style'){
8781 reporter.warn('Style tag can not be use.', event.line, event.col, self, event.raw);
879 }
880 });
881 }
882});
883/**
884 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
885 * MIT Licensed
886 */
8871HTMLHint.addRule({
888 id: 'tag-pair',
889 description: 'Tag must be paired.',
890 init: function(parser, reporter){
8915 var self = this;
8925 var stack=[],
893 mapEmptyTags = parser.makeMap("area,base,basefont,br,col,frame,hr,img,input,isindex,link,meta,param,embed");//HTML 4.01
8945 parser.addListener('tagstart', function(event){
8958 var tagName = event.tagName.toLowerCase();
8968 if (mapEmptyTags[tagName] === undefined && !event.close){
8977 stack.push(tagName);
898 }
899 });
9005 parser.addListener('tagend', function(event){
9014 var tagName = event.tagName.toLowerCase();
902 //向上寻找匹配的开始标签
9034 for(var pos = stack.length-1;pos >= 0; pos--){
9044 if(stack[pos] === tagName){
9053 break;
906 }
907 }
9084 if(pos >= 0){
9093 var arrTags = [];
9103 for(var i=stack.length-1;i>pos;i--){
9111 arrTags.push('</'+stack[i]+'>');
912 }
9133 if(arrTags.length > 0){
9141 reporter.error('Tag must be paired, Missing: [ '+ arrTags.join('') + ' ]', event.line, event.col, self, event.raw);
915 }
9163 stack.length=pos;
917 }
918 else{
9191 reporter.error('Tag must be paired, No start tag: [ ' + event.raw + ' ]', event.line, event.col, self, event.raw);
920 }
921 });
9225 parser.addListener('end', function(event){
9235 var arrTags = [];
9245 for(var i=stack.length-1;i>=0;i--){
9253 arrTags.push('</'+stack[i]+'>');
926 }
9275 if(arrTags.length > 0){
9283 reporter.error('Tag must be paired, Missing: [ '+ arrTags.join('') + ' ]', event.line, event.col, self, '');
929 }
930 });
931 }
932});
933/**
934 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
935 * MIT Licensed
936 */
9371HTMLHint.addRule({
938 id: 'tag-self-close',
939 description: 'The empty tag must closed by self.',
940 init: function(parser, reporter){
9412 var self = this;
9422 var mapEmptyTags = parser.makeMap("area,base,basefont,br,col,frame,hr,img,input,isindex,link,meta,param,embed");//HTML 4.01
9432 parser.addListener('tagstart', function(event){
9444 var tagName = event.tagName.toLowerCase();
9454 if(mapEmptyTags[tagName] !== undefined){
9464 if(!event.close){
9472 reporter.warn('The empty tag : [ '+tagName+' ] must closed by self.', event.line, event.col, self, event.raw);
948 }
949 }
950 });
951 }
952});
953/**
954 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
955 * MIT Licensed
956 */
9571HTMLHint.addRule({
958 id: 'tagname-lowercase',
959 description: 'Tagname must be lowercase.',
960 init: function(parser, reporter){
9614 var self = this;
9624 parser.addListener('tagstart,tagend', function(event){
96313 var tagName = event.tagName;
96413 if(tagName !== tagName.toLowerCase()){
9655 reporter.error('Tagname [ '+tagName+' ] must be lower case.', event.line, event.col, self, event.raw);
966 }
967 });
968 }
969});
\ No newline at end of file +

Coverage

98%
408
402
6

htmlhint.js

98%
408
402
6
LineHitsSource
1/**
2 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
3 * MIT Licensed
4 */
51var HTMLHint = (function (undefined) {
6
71 var HTMLHint = {};
8
91 HTMLHint.version = '@VERSION';
10
111 HTMLHint.rules = {};
12
13 //默认配置
141 HTMLHint.defaultRuleset = {
15 'tagname-lowercase': true,
16 'attr-lowercase': true,
17 'attr-value-double-quotes': true,
18 'doctype-first': true,
19 'tag-pair': true,
20 'spec-char-escape': true,
21 'id-unique': true,
22 'src-not-empty': true,
23 'attr-no-duplication': true
24 };
25
261 HTMLHint.addRule = function(rule){
2721 HTMLHint.rules[rule.id] = rule;
28 };
29
301 HTMLHint.verify = function(html, ruleset){
3180 var id;
32 // parse inline ruleset
3380 html = html.replace(/^\s*<!--\s*htmlhint\s+([^\r\n]+?)\s*-->/i, function(all, strRuleset){
342 if(ruleset === undefined){
350 ruleset = {};
36 }
372 strRuleset.replace(/(?:^|,)\s*([^:]+)\s*:\s*([^,\s]+)/g, function(all, key, value){
382 if(value === 'false'){
391 value = false;
40 }
411 else if(value === 'true'){
421 value = true;
43 }
442 ruleset[key] = value;
45 });
462 return '';
47 });
4880 if(ruleset === undefined){
492 ruleset = HTMLHint.defaultRuleset;
50 }
51
5280 var parser = new HTMLParser();
5380 var reporter = new HTMLHint.Reporter(html.split(/\r?\n/), ruleset);
54
5580 var rules = HTMLHint.rules,
56 rule;
5780 for (id in ruleset){
5896 rule = rules[id];
5996 if (rule !== undefined && ruleset[id] !== false){
6094 rule.init(parser, reporter, ruleset[id]);
61 }
62 }
63
6480 parser.parse(html);
65
6680 return reporter.messages;
67 };
68
691 return HTMLHint;
70
71})();
72
731if (typeof exports === 'object' && exports){
741 exports.HTMLHint = HTMLHint;
75}
76/**
77 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
78 * MIT Licensed
79 */
801(function(HTMLHint, undefined){
81
821 var Reporter = function(){
8380 var self = this;
8480 self._init.apply(self,arguments);
85 };
86
871 Reporter.prototype = {
88 _init: function(lines, ruleset){
8980 var self = this;
9080 self.lines = lines;
9180 self.ruleset = ruleset;
9280 self.messages = [];
93 },
94 //错误
95 error: function(message, line, col, rule, raw){
9647 this.report('error', message, line, col, rule, raw);
97 },
98 //警告
99 warn: function(message, line, col, rule, raw){
10044 this.report('warning', message, line, col, rule, raw);
101 },
102 //信息
103 info: function(message, line, col, rule, raw){
1040 this.report('info', message, line, col, rule, raw);
105 },
106 //报告
107 report: function(type, message, line, col, rule, raw){
10891 var self = this;
10991 self.messages.push({
110 type: type,
111 message: message,
112 raw: raw,
113 evidence: self.lines[line-1],
114 line: line,
115 col: col,
116 rule: {
117 id: rule.id,
118 description: rule.description,
119 link: 'https://github.com/yaniswang/HTMLHint/wiki/' + rule.id
120 }
121 });
122 }
123 };
124
1251 HTMLHint.Reporter = Reporter;
126
127})(HTMLHint);
128/**
129 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
130 * MIT Licensed
131 */
1321var HTMLParser = (function(undefined){
133
1341 var HTMLParser = function(){
135105 var self = this;
136105 self._init.apply(self,arguments);
137 };
138
1391 HTMLParser.prototype = {
140 _init: function(){
141105 var self = this;
142105 self._listeners = {};
143105 self._mapCdataTags = self.makeMap("script,style");
144105 self._arrBlocks = [];
145 },
146
147 makeMap: function(str){
148112 var obj = {}, items = str.split(",");
149112 for ( var i = 0; i < items.length; i++ ){
150308 obj[ items[i] ] = true;
151 }
152112 return obj;
153 },
154
155 // parse html code
156 parse: function(html){
157
158105 var self = this,
159 mapCdataTags = self._mapCdataTags;
160
161105 var regTag=/<(?:\/([^\s>]+)\s*|!--([\s\S]*?)--|!([^>]*?)|([\w\-:]+)((?:\s+[\w\-:]+(?:\s*=\s*(?:"[^"]*"|'[^']*'|[^\s"']+))?)*?)\s*(\/?))>/g,
162 regAttr = /\s*([\w\-:]+)(?:\s*=\s*(?:(")([^"]*)"|(')([^']*)'|([^\s"']+)))?/g,
163 regLine = /\r?\n/g;
164
165105 var match, matchIndex, lastIndex = 0, tagName, arrAttrs, tagCDATA, attrsCDATA, arrCDATA, lastCDATAIndex = 0, text;
166105 var lastLineIndex = 0, line = 1;
167105 var arrBlocks = self._arrBlocks;
168
169105 self.fire('start', {
170 pos: 0,
171 line: 1,
172 col: 1
173 });
174
175105 while((match = regTag.exec(html))){
176252 matchIndex = match.index;
177252 if(matchIndex > lastIndex){//保存前面的文本或者CDATA
17876 text = html.substring(lastIndex, matchIndex);
17976 if(tagCDATA){
18010 arrCDATA.push(text);
181 }
182 else{//文本
18366 saveBlock('text', text, lastIndex);
184 }
185 }
186252 lastIndex = regTag.lastIndex;
187
188252 if((tagName = match[1])){
18989 if(tagCDATA && tagName === tagCDATA){//结束标签前输出CDATA
19015 text = arrCDATA.join('');
19115 saveBlock('cdata', text, lastCDATAIndex, {
192 'tagName': tagCDATA,
193 'attrs': attrsCDATA
194 });
19515 tagCDATA = null;
19615 attrsCDATA = null;
19715 arrCDATA = null;
198 }
19989 if(!tagCDATA){
200 //标签结束
20188 saveBlock('tagend', match[0], matchIndex, {
202 'tagName': tagName
203 });
20488 continue;
205 }
206 }
207
208164 if(tagCDATA){
2091 arrCDATA.push(match[0]);
210 }
211 else{
212163 if((tagName = match[4])){//标签开始
213150 arrAttrs = [];
214150 var attrs = match[5],
215 attrMatch,
216 attrMatchCount = 0;
217150 while((attrMatch = regAttr.exec(attrs))){
218143 var name = attrMatch[1],
219 quote = attrMatch[2] ? attrMatch[2] :
220 attrMatch[4] ? attrMatch[4] : '',
221 value = attrMatch[3] ? attrMatch[3] :
222 attrMatch[5] ? attrMatch[5] :
223 attrMatch[6] ? attrMatch[6] : '';
224143 arrAttrs.push({'name': name, 'value': value, 'quote': quote, 'index': attrMatch.index, 'raw': attrMatch[0]});
225143 attrMatchCount += attrMatch[0].length;
226 }
227150 if(attrMatchCount === attrs.length){
228150 saveBlock('tagstart', match[0], matchIndex, {
229 'tagName': tagName,
230 'attrs': arrAttrs,
231 'close': match[6]
232 });
233150 if(mapCdataTags[tagName]){
23415 tagCDATA = tagName;
23515 attrsCDATA = arrAttrs.concat();
23615 arrCDATA = [];
23715 lastCDATAIndex = lastIndex;
238 }
239 }
240 else{//如果出现漏匹配，则把当前内容匹配为text
2410 saveBlock('text', match[0], matchIndex);
242 }
243 }
24413 else if(match[2] || match[3]){//注释标签
24513 saveBlock('comment', match[0], matchIndex, {
246 'content': match[2] || match[3],
247 'long': match[2]?true:false
248 });
249 }
250 }
251 }
252
253105 if(html.length > lastIndex){
254 //结尾文本
25513 text = html.substring(lastIndex, html.length);
25613 saveBlock('text', text, lastIndex);
257 }
258
259105 self.fire('end', {
260 pos: lastIndex,
261 line: line,
262 col: lastIndex - lastLineIndex + 1
263 });
264
265 //存储区块
266105 function saveBlock(type, raw, pos, data){
267345 var col = pos - lastLineIndex + 1;
268345 if(data === undefined){
26979 data = {};
270 }
271345 data.raw = raw;
272345 data.pos = pos;
273345 data.line = line;
274345 data.col = col;
275345 arrBlocks.push(data);
276345 self.fire(type, data);
277345 var lineMatch;
278345 while((lineMatch = regLine.exec(raw))){
27922 line ++;
28022 lastLineIndex = pos + regLine.lastIndex;
281 }
282 }
283
284 },
285
286 // add event
287 addListener: function(types, listener){
288134 var _listeners = this._listeners;
289134 var arrTypes = types.split(/[,\s]/), type;
290134 for(var i=0, l = arrTypes.length;i<l;i++){
291138 type = arrTypes[i];
292138 if (_listeners[type] === undefined){
293124 _listeners[type] = [];
294 }
295138 _listeners[type].push(listener);
296 }
297 },
298
299 // fire event
300 fire: function(type, data){
301555 if (data === undefined){
3020 data = {};
303 }
304555 data.type = type;
305555 var self = this,
306 listeners = [],
307 listenersType = self._listeners[type],
308 listenersAll = self._listeners['all'];
309555 if (listenersType !== undefined){
310156 listeners = listeners.concat(listenersType);
311 }
312555 if (listenersAll !== undefined){
313130 listeners = listeners.concat(listenersAll);
314 }
315555 for (var i = 0, l = listeners.length; i < l; i++){
316299 listeners[i].call(self, data);
317 }
318 },
319
320 // remove event
321 removeListener: function(type, listener){
32214 var listenersType = this._listeners[type];
32314 if(listenersType !== undefined){
32412 for (var i = 0, l = listenersType.length; i < l; i++){
3259 if (listenersType[i] === listener){
3269 listenersType.splice(i, 1);
3279 break;
328 }
329 }
330 }
331 },
332
333 //fix pos if event.raw have \n
334 fixPos: function(event, index){
3357 var text = event.raw.substr(0, index);
3367 var arrLines = text.split(/\r?\n/),
337 lineCount = arrLines.length - 1,
338 line = event.line, col;
3397 if(lineCount > 0){
3402 line += lineCount;
3412 col = arrLines[lineCount].length + 1;
342 }
343 else{
3445 col = event.col + index;
345 }
3467 return {
347 line: line,
348 col: col
349 };
350 },
351
352 // covert array type of attrs to map
353 getMapAttrs: function(arrAttrs){
3546 var mapAttrs = {},
355 attr;
3566 for(var i=0,l=arrAttrs.length;i<l;i++){
3576 attr = arrAttrs[i];
3586 mapAttrs[attr.name] = attr.value;
359 }
3606 return mapAttrs;
361 }
362 };
363
3641 return HTMLParser;
365
366})();
367
3681if (typeof exports === 'object' && exports){
3691 exports.HTMLParser = HTMLParser;
370}
371/**
372 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
373 * MIT Licensed
374 */
3751HTMLHint.addRule({
376 id: 'attr-lowercase',
377 description: 'Attribute name must be lowercase.',
378 init: function(parser, reporter){
3794 var self = this;
3804 parser.addListener('tagstart', function(event){
3816 var attrs = event.attrs,
382 attr,
383 col = event.col + event.tagName.length + 1;
3846 for(var i=0, l=attrs.length;i<l;i++){
3859 attr = attrs[i];
3869 var attrName = attr.name;
3879 if(attrName !== attrName.toLowerCase()){
3883 reporter.error('Attribute name [ '+attrName+' ] must be lower case.', event.line, col + attr.index, self, attr.raw);
389 }
390 }
391 });
392 }
393});
394/**
395 * Copyright (c) 2014, Yanis Wang <yanis.wang@gmail.com>
396 * MIT Licensed
397 */
3981HTMLHint.addRule({
399 id: 'attr-no-duplication',
400 description: 'Attribute name can not been duplication.',
401 init: function(parser, reporter){
4024 var self = this;
4034 parser.addListener('tagstart', function(event){
4046 var attrs = event.attrs;
4056 var attr;
4066 var attrName;
4076 var col = event.col + event.tagName.length + 1;
408
4096 var mapAttrName = {};
4106 for(var i=0, l=attrs.length;i<l;i++){
41110 attr = attrs[i];
41210 attrName = attr.name;
41310 if(mapAttrName[attrName] === true){
4142 reporter.error('The name of attribute [ '+attr.name+' ] been duplication.', event.line, col + attr.index, self, attr.raw);
415 }
41610 mapAttrName[attrName] = true;
417 }
418 });
419 }
420});
421/**
422 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
423 * MIT Licensed
424 */
4251HTMLHint.addRule({
426 id: 'attr-value-double-quotes',
427 description: 'Attribute value must closed by double quotes.',
428 init: function(parser, reporter){
4294 var self = this;
4304 parser.addListener('tagstart', function(event){
4316 var attrs = event.attrs,
432 attr,
433 col = event.col + event.tagName.length + 1;
4346 for(var i=0, l=attrs.length;i<l;i++){
43513 attr = attrs[i];
43613 if((attr.value !== '' && attr.quote !== '"') ||
437 (attr.value === '' && attr.quote === "'")){
4384 reporter.error('The value of attribute [ '+attr.name+' ] must closed by double quotes.', event.line, col + attr.index, self, attr.raw);
439 }
440 }
441 });
442 }
443});
444/**
445 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
446 * MIT Licensed
447 */
4481HTMLHint.addRule({
449 id: 'attr-value-not-empty',
450 description: 'Attribute must set value.',
451 init: function(parser, reporter){
4523 var self = this;
4533 parser.addListener('tagstart', function(event){
4543 var attrs = event.attrs,
455 attr,
456 col = event.col + event.tagName.length + 1;
4573 for(var i=0, l=attrs.length;i<l;i++){
4583 attr = attrs[i];
4593 if(attr.quote === '' && attr.value === ''){
4601 reporter.warn('The attribute [ '+attr.name+' ] must set value.', event.line, col + attr.index, self, attr.raw);
461 }
462 }
463 });
464 }
465});
466/**
467 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
468 * MIT Licensed
469 */
4701HTMLHint.addRule({
471 id: 'csslint',
472 description: 'Scan css with csslint.',
473 init: function(parser, reporter, options){
4741 var self = this;
4751 parser.addListener('cdata', function(event){
4761 if(event.tagName.toLowerCase() === 'style'){
477
4781 var cssVerify;
479
4801 if(typeof exports === 'object' && require){
4811 cssVerify = require("csslint").CSSLint.verify;
482 }
483 else{
4840 cssVerify = CSSLint.verify;
485 }
486
4871 if(options !== undefined){
4881 var styleLine = event.line - 1,
489 styleCol = event.col - 1;
4901 try{
4911 var messages = cssVerify(event.raw, options).messages;
4921 messages.forEach(function(error){
4932 var line = error.line;
4942 reporter[error.type==='warning'?'warn':'error']('['+error.rule.id+'] '+error.message, styleLine + line, (line === 1 ? styleCol : 0) + error.col, self, error.evidence);
495 });
496 }
497 catch(e){}
498 }
499
500 }
501 });
502 }
503});
504/**
505 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
506 * MIT Licensed
507 */
5081HTMLHint.addRule({
509 id: 'doctype-first',
510 description: 'Doctype must be first.',
511 init: function(parser, reporter){
5124 var self = this;
5134 var allEvent = function(event){
5148 if(event.type === 'start' || (event.type === 'text' && /^\s*$/.test(event.raw))){
5154 return;
516 }
5174 if((event.type !== 'comment' && event.long === false) || /^DOCTYPE\s+/i.test(event.content) === false){
5183 reporter.error('Doctype must be first.', event.line, event.col, self, event.raw);
519 }
5204 parser.removeListener('all', allEvent);
521 };
5224 parser.addListener('all', allEvent);
523 }
524});
525/**
526 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
527 * MIT Licensed
528 */
5291HTMLHint.addRule({
530 id: 'doctype-html5',
531 description: 'Doctype must be html5.',
532 init: function(parser, reporter){
5332 var self = this;
5342 function onComment(event){
5359 if(event.long === false && event.content.toLowerCase() !== 'doctype html'){
5361 reporter.warn('Doctype must be html5.', event.line, event.col, self, event.raw);
537 }
538 }
5392 function onTagStart(){
5402 parser.removeListener('comment', onComment);
5412 parser.removeListener('tagstart', onTagStart);
542 }
5432 parser.addListener('all', onComment);
5442 parser.addListener('tagstart', onTagStart);
545 }
546});
547/**
548 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
549 * MIT Licensed
550 */
5511HTMLHint.addRule({
552 id: 'head-script-disabled',
553 description: 'The script tag can not be used in head.',
554 init: function(parser, reporter){
5553 var self = this;
5563 function onTagStart(event){
5575 if(event.tagName.toLowerCase() === 'script'){
5582 reporter.warn('The script tag can not be used in head.', event.line, event.col, self, event.raw);
559 }
560 }
5613 function onTagEnd(event){
5627 if(event.tagName.toLowerCase() === 'head'){
5633 parser.removeListener('tagstart', onTagStart);
5643 parser.removeListener('tagstart', onTagEnd);
565 }
566 }
5673 parser.addListener('tagstart', onTagStart);
5683 parser.addListener('tagend', onTagEnd);
569 }
570});
571/**
572 * Copyright (c) 2014, Yanis Wang <yanis.wang@gmail.com>
573 * MIT Licensed
574 */
5751HTMLHint.addRule({
576 id: 'href-abs-or-rel',
577 description: 'Href must be absolute or relative.',
578 init: function(parser, reporter, options){
5794 var self = this;
580
5814 var hrefMode = options === 'abs' ? 'absolute' : 'relative';
582
5834 parser.addListener('tagstart', function(event){
58416 var attrs = event.attrs;
58516 var attr;
58616 var col = event.col + event.tagName.length + 1;
587
58816 for(var i=0, l=attrs.length;i<l;i++){
58916 attr = attrs[i];
59016 if(attr.name === 'href'){
59116 if((hrefMode === 'absolute' && /^\w+?:/.test(attr.value) === false) ||
592 (hrefMode === 'relative' && /^https?:\/\//.test(attr.value) === true)){
5934 reporter.error('The value of href [ '+attr.value+' ] must be '+hrefMode+'.', event.line, col + attr.index, self, attr.raw);
594 }
59516 break;
596 }
597 }
598 });
599 }
600});
601/**
602 * Copyright (c) 2014, Yanis Wang <yanis.wang@gmail.com>
603 * MIT Licensed
604 */
6051HTMLHint.addRule({
606 id: 'id-class-ad-disabled',
607 description: 'Id and class can not use ad keyword, it will blocked by adblock software.',
608 init: function(parser, reporter){
60917 var self = this;
61017 parser.addListener('tagstart', function(event){
61117 var attrs = event.attrs;
61217 var attr;
61317 var attrName;
61417 var col = event.col + event.tagName.length + 1;
615
61617 for(var i=0, l=attrs.length;i<l;i++){
61720 attr = attrs[i];
61820 attrName = attr.name;
61920 if(/^(id|class)$/i.test(attrName)){
62020 if(/(^|[-\_])ad([-\_]|$)/i.test(attr.value)){
62114 reporter.warn('The value of '+attrName+' can not use ad keyword.', event.line, col + attr.index, self, attr.raw);
622 }
623 }
624 }
625 });
626 }
627});
628/**
629 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
630 * MIT Licensed
631 */
6321HTMLHint.addRule({
633 id: 'id-class-value',
634 description: 'Id and class value must meet some rules.',
635 init: function(parser, reporter, options){
6368 var self = this;
6378 var arrRules = {
638 'underline': {
639 'regId': /^[a-z\d]+(_[a-z\d]+)*$/,
640 'message': 'Id and class value must lower case and split by underline.'
641 },
642 'dash': {
643 'regId': /^[a-z\d]+(-[a-z\d]+)*$/,
644 'message': 'Id and class value must lower case and split by dash.'
645 },
646 'hump': {
647 'regId': /^[a-z][a-zA-Z\d]*([A-Z][a-zA-Z\d]*)*$/,
648 'message': 'Id and class value must meet hump style.'
649 }
650 }, rule;
6518 if(typeof options === 'string'){
6526 rule = arrRules[options];
653 }
654 else{
6552 rule = options;
656 }
6578 if(rule && rule.regId){
6588 var regId = rule.regId,
659 message = rule.message;
6608 parser.addListener('tagstart', function(event){
6618 var attrs = event.attrs,
662 attr,
663 col = event.col + event.tagName.length + 1;
6648 for(var i=0, l1=attrs.length;i<l1;i++){
66516 attr = attrs[i];
66616 if(attr.name.toLowerCase() === 'id'){
6678 if(regId.test(attr.value) === false){
6684 reporter.warn(message, event.line, col + attr.index, self, attr.raw);
669 }
670 }
67116 if(attr.name.toLowerCase() === 'class'){
6728 var arrClass = attr.value.split(/\s+/g), classValue;
6738 for(var j=0, l2=arrClass.length;j<l2;j++){
6748 classValue = arrClass[j];
6758 if(classValue && regId.test(classValue) === false){
6764 reporter.warn(message, event.line, col + attr.index, self, classValue);
677 }
678 }
679 }
680 }
681 });
682 }
683 }
684});
685/**
686 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
687 * MIT Licensed
688 */
6891HTMLHint.addRule({
690 id: 'id-unique',
691 description: 'Id must be unique.',
692 init: function(parser, reporter){
6934 var self = this;
6944 var mapIdCount = {};
6954 parser.addListener('tagstart', function(event){
6968 var attrs = event.attrs,
697 attr,
698 id,
699 col = event.col + event.tagName.length + 1;
7008 for(var i=0, l=attrs.length;i<l;i++){
70111 attr = attrs[i];
70211 if(attr.name.toLowerCase() === 'id'){
7036 id = attr.value;
7046 if(id){
7056 if(mapIdCount[id] === undefined){
7064 mapIdCount[id] = 1;
707 }
708 else{
7092 mapIdCount[id] ++;
710 }
7116 if(mapIdCount[id] > 1){
7122 reporter.error('Id redefinition of [ '+id+' ].', event.line, col + attr.index, self, attr.raw);
713 }
714 }
7156 break;
716 }
717 }
718 });
719 }
720});
721/**
722 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
723 * MIT Licensed
724 */
7251HTMLHint.addRule({
726 id: 'img-alt-require',
727 description: 'Alt of img tag must be set value.',
728 init: function(parser, reporter){
7294 var self = this;
7304 parser.addListener('tagstart', function(event){
7314 if(event.tagName.toLowerCase() === 'img'){
7324 var attrs = event.attrs;
7334 var haveAlt = false;
7344 for(var i=0, l=attrs.length;i<l;i++){
7359 if(attrs[i].name.toLowerCase() === 'alt'){
7362 haveAlt = true;
7372 break;
738 }
739 }
7404 if(haveAlt === false){
7412 reporter.warn('Alt of img tag must be set value.', event.line, event.col, self, event.raw);
742 }
743 }
744 });
745 }
746});
747/**
748 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
749 * MIT Licensed
750 */
7511HTMLHint.addRule({
752 id: 'jshint',
753 description: 'Scan script with jshint.',
754 init: function(parser, reporter, options){
7554 var self = this;
7564 parser.addListener('cdata', function(event){
7574 if(event.tagName.toLowerCase() === 'script'){
758
7594 var mapAttrs = parser.getMapAttrs(event.attrs),
760 type = mapAttrs.type;
761
762 // Only scan internal javascript
7634 if(mapAttrs.src !== undefined || (type && /^(text\/javascript)$/i.test(type) === false)){
7642 return;
765 }
766
7672 var jsVerify;
768
7692 if(typeof exports === 'object' && require){
7702 jsVerify = require('jshint').JSHINT;
771 }
772 else{
7730 jsVerify = JSHINT;
774 }
775
7762 if(options !== undefined){
7772 var styleLine = event.line - 1,
778 styleCol = event.col - 1;
7792 var code = event.raw.replace(/\t/g,' ');
7802 try{
7812 var status = jsVerify(code, options);
7822 if(status === false){
7832 jsVerify.errors.forEach(function(error){
7848 var line = error.line;
7858 reporter.warn(error.reason, styleLine + line, (line === 1 ? styleCol : 0) + error.character, self, error.evidence);
786 });
787 }
788 }
789 catch(e){}
790 }
791
792 }
793 });
794 }
795});
796/**
797 * Copyright (c) 2014, Yanis Wang <yanis.wang@gmail.com>
798 * MIT Licensed
799 */
8001HTMLHint.addRule({
801 id: 'space-tab-mixed-disabled',
802 description: 'Spaces and tabs can not mixed in front of line.',
803 init: function(parser, reporter){
8046 var self = this;
8056 parser.addListener('text', function(event){
80612 var raw = event.raw;
80712 var reMixed = /(^|\r?\n)( +\t|\t+ )/g;
80812 var match;
80912 while((match = reMixed.exec(raw))){
8103 var fixedPos = parser.fixPos(event, match.index + match[1].length);
8113 reporter.warn('Mixed spaces and tabs in front of line.', fixedPos.line, 1, self, event.raw);
812 }
813 });
814 }
815});
816/**
817 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
818 * MIT Licensed
819 */
8201HTMLHint.addRule({
821 id: 'spec-char-escape',
822 description: 'Special characters must be escaped.',
823 init: function(parser, reporter){
8244 var self = this;
8254 parser.addListener('text', function(event){
8264 var raw = event.raw,
827 reSpecChar = /[<>]/g,
828 match;
8294 while((match = reSpecChar.exec(raw))){
8304 var fixedPos = parser.fixPos(event, match.index);
8314 reporter.error('Special characters must be escaped : [ '+match[0]+' ].', fixedPos.line, fixedPos.col, self, event.raw);
832 }
833 });
834 }
835});
836/**
837 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
838 * MIT Licensed
839 */
8401HTMLHint.addRule({
841 id: 'src-not-empty',
842 description: 'Src of img(script,link) must set value.',
843 init: function(parser, reporter){
8445 var self = this;
8455 parser.addListener('tagstart', function(event){
84632 var tagName = event.tagName,
847 attrs = event.attrs,
848 attr,
849 col = event.col + tagName.length + 1;
85032 for(var i=0, l=attrs.length;i<l;i++){
85136 attr = attrs[i];
85236 if(((/^(img|script|embed|bgsound|iframe)$/.test(tagName) === true && attr.name === 'src') ||
853 (tagName === 'link' && attr.name === 'href') ||
854 (tagName === 'object' && attr.name === 'data')) &&
855 attr.value === ''){
85615 reporter.error('[ '+attr.name + '] of [ '+tagName+' ] must set value.', event.line, col + attr.index, self, attr.raw);
857 }
858 }
859 });
860 }
861});
862/**
863 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
864 * MIT Licensed
865 */
8661HTMLHint.addRule({
867 id: 'style-disabled',
868 description: 'Style tag can not be use.',
869 init: function(parser, reporter){
8702 var self = this;
8712 parser.addListener('tagstart', function(event){
8724 if(event.tagName.toLowerCase() === 'style'){
8731 reporter.warn('Style tag can not be use.', event.line, event.col, self, event.raw);
874 }
875 });
876 }
877});
878/**
879 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
880 * MIT Licensed
881 */
8821HTMLHint.addRule({
883 id: 'tag-pair',
884 description: 'Tag must be paired.',
885 init: function(parser, reporter){
8865 var self = this;
8875 var stack=[],
888 mapEmptyTags = parser.makeMap("area,base,basefont,br,col,frame,hr,img,input,isindex,link,meta,param,embed");//HTML 4.01
8895 parser.addListener('tagstart', function(event){
8908 var tagName = event.tagName.toLowerCase();
8918 if (mapEmptyTags[tagName] === undefined && !event.close){
8927 stack.push(tagName);
893 }
894 });
8955 parser.addListener('tagend', function(event){
8964 var tagName = event.tagName.toLowerCase();
897 //向上寻找匹配的开始标签
8984 for(var pos = stack.length-1;pos >= 0; pos--){
8994 if(stack[pos] === tagName){
9003 break;
901 }
902 }
9034 if(pos >= 0){
9043 var arrTags = [];
9053 for(var i=stack.length-1;i>pos;i--){
9061 arrTags.push('</'+stack[i]+'>');
907 }
9083 if(arrTags.length > 0){
9091 reporter.error('Tag must be paired, Missing: [ '+ arrTags.join('') + ' ]', event.line, event.col, self, event.raw);
910 }
9113 stack.length=pos;
912 }
913 else{
9141 reporter.error('Tag must be paired, No start tag: [ ' + event.raw + ' ]', event.line, event.col, self, event.raw);
915 }
916 });
9175 parser.addListener('end', function(event){
9185 var arrTags = [];
9195 for(var i=stack.length-1;i>=0;i--){
9203 arrTags.push('</'+stack[i]+'>');
921 }
9225 if(arrTags.length > 0){
9233 reporter.error('Tag must be paired, Missing: [ '+ arrTags.join('') + ' ]', event.line, event.col, self, '');
924 }
925 });
926 }
927});
928/**
929 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
930 * MIT Licensed
931 */
9321HTMLHint.addRule({
933 id: 'tag-self-close',
934 description: 'The empty tag must closed by self.',
935 init: function(parser, reporter){
9362 var self = this;
9372 var mapEmptyTags = parser.makeMap("area,base,basefont,br,col,frame,hr,img,input,isindex,link,meta,param,embed");//HTML 4.01
9382 parser.addListener('tagstart', function(event){
9394 var tagName = event.tagName.toLowerCase();
9404 if(mapEmptyTags[tagName] !== undefined){
9414 if(!event.close){
9422 reporter.warn('The empty tag : [ '+tagName+' ] must closed by self.', event.line, event.col, self, event.raw);
943 }
944 }
945 });
946 }
947});
948/**
949 * Copyright (c) 2013, Yanis Wang <yanis.wang@gmail.com>
950 * MIT Licensed
951 */
9521HTMLHint.addRule({
953 id: 'tagname-lowercase',
954 description: 'Tagname must be lowercase.',
955 init: function(parser, reporter){
9564 var self = this;
9574 parser.addListener('tagstart,tagend', function(event){
95813 var tagName = event.tagName;
95913 if(tagName !== tagName.toLowerCase()){
9605 reporter.error('Tagname [ '+tagName+' ] must be lower case.', event.line, event.col, self, event.raw);
961 }
962 });
963 }
964});
\ No newline at end of file diff --git a/lib/htmlhint.js b/lib/htmlhint.js index 09d795009..322cf29e1 100644 --- a/lib/htmlhint.js +++ b/lib/htmlhint.js @@ -5,4 +5,4 @@ * (c) 2013 Yanis Wang . * MIT Licensed */ -var HTMLHint=function(e){var t={};return t.version="0.9.6",t.rules={},t.defaultRuleset={"tagname-lowercase":!0,"attr-lowercase":!0,"attr-value-double-quotes":!0,"doctype-first":!0,"tag-pair":!0,"spec-char-escape":!0,"id-unique":!0,"src-not-empty":!0,"attr-no-duplication":!0},t.addRule=function(e){t.rules[e.id]=e},t.verify=function(a,n){var i,r;if(a=a.replace(/^\s*/i,function(e,t){return r={},t.replace(/(?:^|,)\s*([^:]+)\s*:\s*([^,\s]+)/g,function(e,t,a){"false"===a?a=!1:"true"===a&&(a=!0),r[t]=a}),""}),n!==e){r=r||{};for(i in n)r[i]=n[i]}r===e&&(r=t.defaultRuleset);var s,o=new HTMLParser,l=new t.Reporter(a.split(/\r?\n/),r),d=t.rules;for(i in r)s=d[i],s!==e&&r[i]!==!1&&s.init(o,l,r[i]);return o.parse(a),l.messages},t}();"object"==typeof exports&&exports&&(exports.HTMLHint=HTMLHint),function(e){var t=function(){var e=this;e._init.apply(e,arguments)};t.prototype={_init:function(e,t){var a=this;a.lines=e,a.ruleset=t,a.messages=[]},error:function(e,t,a,n,i){this.report("error",e,t,a,n,i)},warn:function(e,t,a,n,i){this.report("warning",e,t,a,n,i)},info:function(e,t,a,n,i){this.report("info",e,t,a,n,i)},report:function(e,t,a,n,i,r){var s=this;s.messages.push({type:e,message:t,raw:r,evidence:s.lines[a-1],line:a,col:n,rule:{id:i.id,description:i.description,link:"https://github.com/yaniswang/HTMLHint/wiki/"+i.id}})}},e.Reporter=t}(HTMLHint);var HTMLParser=function(e){var t=function(){var e=this;e._init.apply(e,arguments)};return t.prototype={_init:function(){var e=this;e._listeners={},e._mapCdataTags=e.makeMap("script,style"),e._arrBlocks=[]},makeMap:function(e){for(var t={},a=e.split(","),n=0;a.length>n;n++)t[a[n]]=!0;return t},parse:function(t){function a(t,a,n,i){var r=n-w+1;i===e&&(i={}),i.raw=a,i.pos=n,i.line=b,i.col=r,L.push(i),u.fire(t,i);for(var s;s=p.exec(a);)b++,w=n+p.lastIndex}var n,i,r,s,o,l,d,c,u=this,f=u._mapCdataTags,g=/<(?:\/([^\s>]+)\s*|!--([\s\S]*?)--|!([^>]*?)|([\w\-:]+)((?:\s+[\w\-:]+(?:\s*=\s*(?:"[^"]*"|'[^']*'|[^\s"']+))?)*?)\s*(\/?))>/g,m=/\s*([\w\-:]+)(?:\s*=\s*(?:(")([^"]*)"|(')([^']*)'|([^\s"']+)))?/g,p=/\r?\n/g,v=0,h=0,w=0,b=1,L=u._arrBlocks;for(u.fire("start",{pos:0,line:1,col:1});n=g.exec(t);)if(i=n.index,i>v&&(c=t.substring(v,i),o?d.push(c):a("text",c,v)),v=g.lastIndex,!(r=n[1])||(o&&r===o&&(c=d.join(""),a("cdata",c,h,{tagName:o,attrs:l}),o=null,l=null,d=null),o))if(o)d.push(n[0]);else if(r=n[4]){s=[];for(var H,y=n[5],T=0;H=m.exec(y);){var x=H[1],M=H[2]?H[2]:H[4]?H[4]:"",R=H[3]?H[3]:H[5]?H[5]:H[6]?H[6]:"";s.push({name:x,value:R,quote:M,index:H.index,raw:H[0]}),T+=H[0].length}T===y.length?(a("tagstart",n[0],i,{tagName:r,attrs:s,close:n[6]}),f[r]&&(o=r,l=s.concat(),d=[],h=v)):a("text",n[0],i)}else(n[2]||n[3])&&a("comment",n[0],i,{content:n[2]||n[3],"long":n[2]?!0:!1});else a("tagend",n[0],i,{tagName:r});t.length>v&&(c=t.substring(v,t.length),a("text",c,v)),u.fire("end",{pos:v,line:b,col:v-w+1})},addListener:function(t,a){for(var n,i=this._listeners,r=t.split(/[,\s]/),s=0,o=r.length;o>s;s++)n=r[s],i[n]===e&&(i[n]=[]),i[n].push(a)},fire:function(t,a){a===e&&(a={}),a.type=t;var n=this,i=[],r=n._listeners[t],s=n._listeners.all;r!==e&&(i=i.concat(r)),s!==e&&(i=i.concat(s));for(var o=0,l=i.length;l>o;o++)i[o].call(n,a)},removeListener:function(t,a){var n=this._listeners[t];if(n!==e)for(var i=0,r=n.length;r>i;i++)if(n[i]===a){n.splice(i,1);break}},fixPos:function(e,t){var a,n=e.raw.substr(0,t),i=n.split(/\r?\n/),r=i.length-1,s=e.line;return r>0?(s+=r,a=i[r].length+1):a=e.col+t,{line:s,col:a}},getMapAttrs:function(e){for(var t,a={},n=0,i=e.length;i>n;n++)t=e[n],a[t.name]=t.value;return a}},t}();"object"==typeof exports&&exports&&(exports.HTMLParser=HTMLParser),HTMLHint.addRule({id:"attr-lowercase",description:"Attribute name must be lowercase.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i=e.attrs,r=e.col+e.tagName.length+1,s=0,o=i.length;o>s;s++){n=i[s];var l=n.name;l!==l.toLowerCase()&&t.error("Attribute name [ "+l+" ] must be lower case.",e.line,r+n.index,a,n.raw)}})}}),HTMLHint.addRule({id:"attr-no-duplication",description:"Attribute name can not been duplication.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i,r=e.attrs,s=e.col+e.tagName.length+1,o={},l=0,d=r.length;d>l;l++)n=r[l],i=n.name,o[i]===!0&&t.error("The name of attribute [ "+n.name+" ] been duplication.",e.line,s+n.index,a,n.raw),o[i]=!0})}}),HTMLHint.addRule({id:"attr-value-double-quotes",description:"Attribute value must closed by double quotes.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i=e.attrs,r=e.col+e.tagName.length+1,s=0,o=i.length;o>s;s++)n=i[s],(""!==n.value&&'"'!==n.quote||""===n.value&&"'"===n.quote)&&t.error("The value of attribute [ "+n.name+" ] must closed by double quotes.",e.line,r+n.index,a,n.raw)})}}),HTMLHint.addRule({id:"attr-value-not-empty",description:"Attribute must set value.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i=e.attrs,r=e.col+e.tagName.length+1,s=0,o=i.length;o>s;s++)n=i[s],""===n.quote&&""===n.value&&t.warn("The attribute [ "+n.name+" ] must set value.",e.line,r+n.index,a,n.raw)})}}),HTMLHint.addRule({id:"csslint",description:"Scan css with csslint.",init:function(e,t,a){var n=this;e.addListener("cdata",function(e){if("style"===e.tagName.toLowerCase()){var i;if(i="object"==typeof exports&&require?require("csslint").CSSLint.verify:CSSLint.verify,void 0!==a){var r=e.line-1,s=e.col-1;try{var o=i(e.raw,a).messages;o.forEach(function(e){var a=e.line;t["warning"===e.type?"warn":"error"]("["+e.rule.id+"] "+e.message,r+a,(1===a?s:0)+e.col,n,e.evidence)})}catch(l){}}}})}}),HTMLHint.addRule({id:"doctype-first",description:"Doctype must be first.",init:function(e,t){var a=this,n=function(i){"start"===i.type||"text"===i.type&&/^\s*$/.test(i.raw)||(("comment"!==i.type&&i.long===!1||/^DOCTYPE\s+/i.test(i.content)===!1)&&t.error("Doctype must be first.",i.line,i.col,a,i.raw),e.removeListener("all",n))};e.addListener("all",n)}}),HTMLHint.addRule({id:"doctype-html5",description:"Doctype must be html5.",init:function(e,t){function a(e){e.long===!1&&"doctype html"!==e.content.toLowerCase()&&t.warn("Doctype must be html5.",e.line,e.col,i,e.raw)}function n(){e.removeListener("comment",a),e.removeListener("tagstart",n)}var i=this;e.addListener("all",a),e.addListener("tagstart",n)}}),HTMLHint.addRule({id:"head-script-disabled",description:"The script tag can not be used in head.",init:function(e,t){function a(e){"script"===e.tagName.toLowerCase()&&t.warn("The script tag can not be used in head.",e.line,e.col,i,e.raw)}function n(t){"head"===t.tagName.toLowerCase()&&(e.removeListener("tagstart",a),e.removeListener("tagstart",n))}var i=this;e.addListener("tagstart",a),e.addListener("tagend",n)}}),HTMLHint.addRule({id:"href-abs-or-rel",description:"Href must be absolute or relative.",init:function(e,t,a){var n=this,i="abs"===a?"absolute":"relative";e.addListener("tagstart",function(e){for(var a,r=e.attrs,s=e.col+e.tagName.length+1,o=0,l=r.length;l>o;o++)if(a=r[o],"href"===a.name){("absolute"===i&&/^\w+?:/.test(a.value)===!1||"relative"===i&&/^https?:\/\//.test(a.value)===!0)&&t.error("The value of href [ "+a.value+" ] must be "+i+".",e.line,s+a.index,n,a.raw);break}})}}),HTMLHint.addRule({id:"id-class-ad-disabled",description:"Id and class can not use ad keyword, it will blocked by adblock software.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i,r=e.attrs,s=e.col+e.tagName.length+1,o=0,l=r.length;l>o;o++)n=r[o],i=n.name,/^(id|class)$/i.test(i)&&/(^|[-\_])ad([-\_]|$)/i.test(n.value)&&t.warn("The value of "+i+" can not use ad keyword.",e.line,s+n.index,a,n.raw)})}}),HTMLHint.addRule({id:"id-class-value",description:"Id and class value must meet some rules.",init:function(e,t,a){var n,i=this,r={underline:{regId:/^[a-z\d]+(_[a-z\d]+)*$/,message:"Id and class value must lower case and split by underline."},dash:{regId:/^[a-z\d]+(-[a-z\d]+)*$/,message:"Id and class value must lower case and split by dash."},hump:{regId:/^[a-z][a-zA-Z\d]*([A-Z][a-zA-Z\d]*)*$/,message:"Id and class value must meet hump style."}};if(n="string"==typeof a?r[a]:a,n&&n.regId){var s=n.regId,o=n.message;e.addListener("tagstart",function(e){for(var a,n=e.attrs,r=e.col+e.tagName.length+1,l=0,d=n.length;d>l;l++)if(a=n[l],"id"===a.name.toLowerCase()&&s.test(a.value)===!1&&t.warn(o,e.line,r+a.index,i,a.raw),"class"===a.name.toLowerCase())for(var c,u=a.value.split(/\s+/g),f=0,g=u.length;g>f;f++)c=u[f],c&&s.test(c)===!1&&t.warn(o,e.line,r+a.index,i,c)})}}}),HTMLHint.addRule({id:"id-unique",description:"Id must be unique.",init:function(e,t){var a=this,n={};e.addListener("tagstart",function(e){for(var i,r,s=e.attrs,o=e.col+e.tagName.length+1,l=0,d=s.length;d>l;l++)if(i=s[l],"id"===i.name.toLowerCase()){r=i.value,r&&(void 0===n[r]?n[r]=1:n[r]++,n[r]>1&&t.error("Id redefinition of [ "+r+" ].",e.line,o+i.index,a,i.raw));break}})}}),HTMLHint.addRule({id:"img-alt-require",description:"Alt of img tag must be set value.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){if("img"===e.tagName.toLowerCase()){for(var n=e.attrs,i=!1,r=0,s=n.length;s>r;r++)if("alt"===n[r].name.toLowerCase()){i=!0;break}i===!1&&t.warn("Alt of img tag must be set value.",e.line,e.col,a,e.raw)}})}}),HTMLHint.addRule({id:"jshint",description:"Scan script with jshint.",init:function(e,t,a){var n=this;e.addListener("cdata",function(i){if("script"===i.tagName.toLowerCase()){var r=e.getMapAttrs(i.attrs),s=r.type;if(void 0!==r.src||s&&/^(text\/javascript)$/i.test(s)===!1)return;var o;if(o="object"==typeof exports&&require?require("jshint").JSHINT:JSHINT,void 0!==a){var l=i.line-1,d=i.col-1,c=i.raw.replace(/\t/g," ");try{var u=o(c,a);u===!1&&o.errors.forEach(function(e){var a=e.line;t.warn(e.reason,l+a,(1===a?d:0)+e.character,n,e.evidence)})}catch(f){}}}})}}),HTMLHint.addRule({id:"space-tab-mixed-disabled",description:"Spaces and tabs can not mixed in front of line.",init:function(e,t){var a=this;e.addListener("text",function(n){for(var i,r=n.raw,s=/(^|\r?\n)( +\t|\t+ )/g;i=s.exec(r);){var o=e.fixPos(n,i.index+i[1].length);t.warn("Mixed spaces and tabs in front of line.",o.line,1,a,n.raw)}})}}),HTMLHint.addRule({id:"spec-char-escape",description:"Special characters must be escaped.",init:function(e,t){var a=this;e.addListener("text",function(n){for(var i,r=n.raw,s=/[<>]/g;i=s.exec(r);){var o=e.fixPos(n,i.index);t.error("Special characters must be escaped : [ "+i[0]+" ].",o.line,o.col,a,n.raw)}})}}),HTMLHint.addRule({id:"src-not-empty",description:"Src of img(script,link) must set value.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i=e.tagName,r=e.attrs,s=e.col+i.length+1,o=0,l=r.length;l>o;o++)n=r[o],(/^(img|script|embed|bgsound|iframe)$/.test(i)===!0&&"src"===n.name||"link"===i&&"href"===n.name||"object"===i&&"data"===n.name)&&""===n.value&&t.error("[ "+n.name+"] of [ "+i+" ] must set value.",e.line,s+n.index,a,n.raw)})}}),HTMLHint.addRule({id:"style-disabled",description:"Style tag can not be use.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){"style"===e.tagName.toLowerCase()&&t.warn("Style tag can not be use.",e.line,e.col,a,e.raw)})}}),HTMLHint.addRule({id:"tag-pair",description:"Tag must be paired.",init:function(e,t){var a=this,n=[],i=e.makeMap("area,base,basefont,br,col,frame,hr,img,input,isindex,link,meta,param,embed");e.addListener("tagstart",function(e){var t=e.tagName.toLowerCase();void 0!==i[t]||e.close||n.push(t)}),e.addListener("tagend",function(e){for(var i=e.tagName.toLowerCase(),r=n.length-1;r>=0&&n[r]!==i;r--);if(r>=0){for(var s=[],o=n.length-1;o>r;o--)s.push("");s.length>0&&t.error("Tag must be paired, Missing: [ "+s.join("")+" ]",e.line,e.col,a,e.raw),n.length=r}else t.error("Tag must be paired, No start tag: [ "+e.raw+" ]",e.line,e.col,a,e.raw)}),e.addListener("end",function(e){for(var i=[],r=n.length-1;r>=0;r--)i.push("");i.length>0&&t.error("Tag must be paired, Missing: [ "+i.join("")+" ]",e.line,e.col,a,"")})}}),HTMLHint.addRule({id:"tag-self-close",description:"The empty tag must closed by self.",init:function(e,t){var a=this,n=e.makeMap("area,base,basefont,br,col,frame,hr,img,input,isindex,link,meta,param,embed");e.addListener("tagstart",function(e){var i=e.tagName.toLowerCase();void 0!==n[i]&&(e.close||t.warn("The empty tag : [ "+i+" ] must closed by self.",e.line,e.col,a,e.raw))})}}),HTMLHint.addRule({id:"tagname-lowercase",description:"Tagname must be lowercase.",init:function(e,t){var a=this;e.addListener("tagstart,tagend",function(e){var n=e.tagName;n!==n.toLowerCase()&&t.error("Tagname [ "+n+" ] must be lower case.",e.line,e.col,a,e.raw)})}}); \ No newline at end of file +var HTMLHint=function(e){var t={};return t.version="0.9.6",t.rules={},t.defaultRuleset={"tagname-lowercase":!0,"attr-lowercase":!0,"attr-value-double-quotes":!0,"doctype-first":!0,"tag-pair":!0,"spec-char-escape":!0,"id-unique":!0,"src-not-empty":!0,"attr-no-duplication":!0},t.addRule=function(e){t.rules[e.id]=e},t.verify=function(a,n){var i;a=a.replace(/^\s*/i,function(t,a){return n===e&&(n={}),a.replace(/(?:^|,)\s*([^:]+)\s*:\s*([^,\s]+)/g,function(e,t,a){"false"===a?a=!1:"true"===a&&(a=!0),n[t]=a}),""}),n===e&&(n=t.defaultRuleset);var r,s=new HTMLParser,o=new t.Reporter(a.split(/\r?\n/),n),l=t.rules;for(i in n)r=l[i],r!==e&&n[i]!==!1&&r.init(s,o,n[i]);return s.parse(a),o.messages},t}();"object"==typeof exports&&exports&&(exports.HTMLHint=HTMLHint),function(e){var t=function(){var e=this;e._init.apply(e,arguments)};t.prototype={_init:function(e,t){var a=this;a.lines=e,a.ruleset=t,a.messages=[]},error:function(e,t,a,n,i){this.report("error",e,t,a,n,i)},warn:function(e,t,a,n,i){this.report("warning",e,t,a,n,i)},info:function(e,t,a,n,i){this.report("info",e,t,a,n,i)},report:function(e,t,a,n,i,r){var s=this;s.messages.push({type:e,message:t,raw:r,evidence:s.lines[a-1],line:a,col:n,rule:{id:i.id,description:i.description,link:"https://github.com/yaniswang/HTMLHint/wiki/"+i.id}})}},e.Reporter=t}(HTMLHint);var HTMLParser=function(e){var t=function(){var e=this;e._init.apply(e,arguments)};return t.prototype={_init:function(){var e=this;e._listeners={},e._mapCdataTags=e.makeMap("script,style"),e._arrBlocks=[]},makeMap:function(e){for(var t={},a=e.split(","),n=0;a.length>n;n++)t[a[n]]=!0;return t},parse:function(t){function a(t,a,n,i){var r=n-w+1;i===e&&(i={}),i.raw=a,i.pos=n,i.line=b,i.col=r,L.push(i),u.fire(t,i);for(var s;s=p.exec(a);)b++,w=n+p.lastIndex}var n,i,r,s,o,l,d,c,u=this,f=u._mapCdataTags,g=/<(?:\/([^\s>]+)\s*|!--([\s\S]*?)--|!([^>]*?)|([\w\-:]+)((?:\s+[\w\-:]+(?:\s*=\s*(?:"[^"]*"|'[^']*'|[^\s"']+))?)*?)\s*(\/?))>/g,m=/\s*([\w\-:]+)(?:\s*=\s*(?:(")([^"]*)"|(')([^']*)'|([^\s"']+)))?/g,p=/\r?\n/g,v=0,h=0,w=0,b=1,L=u._arrBlocks;for(u.fire("start",{pos:0,line:1,col:1});n=g.exec(t);)if(i=n.index,i>v&&(c=t.substring(v,i),o?d.push(c):a("text",c,v)),v=g.lastIndex,!(r=n[1])||(o&&r===o&&(c=d.join(""),a("cdata",c,h,{tagName:o,attrs:l}),o=null,l=null,d=null),o))if(o)d.push(n[0]);else if(r=n[4]){s=[];for(var H,y=n[5],T=0;H=m.exec(y);){var x=H[1],M=H[2]?H[2]:H[4]?H[4]:"",R=H[3]?H[3]:H[5]?H[5]:H[6]?H[6]:"";s.push({name:x,value:R,quote:M,index:H.index,raw:H[0]}),T+=H[0].length}T===y.length?(a("tagstart",n[0],i,{tagName:r,attrs:s,close:n[6]}),f[r]&&(o=r,l=s.concat(),d=[],h=v)):a("text",n[0],i)}else(n[2]||n[3])&&a("comment",n[0],i,{content:n[2]||n[3],"long":n[2]?!0:!1});else a("tagend",n[0],i,{tagName:r});t.length>v&&(c=t.substring(v,t.length),a("text",c,v)),u.fire("end",{pos:v,line:b,col:v-w+1})},addListener:function(t,a){for(var n,i=this._listeners,r=t.split(/[,\s]/),s=0,o=r.length;o>s;s++)n=r[s],i[n]===e&&(i[n]=[]),i[n].push(a)},fire:function(t,a){a===e&&(a={}),a.type=t;var n=this,i=[],r=n._listeners[t],s=n._listeners.all;r!==e&&(i=i.concat(r)),s!==e&&(i=i.concat(s));for(var o=0,l=i.length;l>o;o++)i[o].call(n,a)},removeListener:function(t,a){var n=this._listeners[t];if(n!==e)for(var i=0,r=n.length;r>i;i++)if(n[i]===a){n.splice(i,1);break}},fixPos:function(e,t){var a,n=e.raw.substr(0,t),i=n.split(/\r?\n/),r=i.length-1,s=e.line;return r>0?(s+=r,a=i[r].length+1):a=e.col+t,{line:s,col:a}},getMapAttrs:function(e){for(var t,a={},n=0,i=e.length;i>n;n++)t=e[n],a[t.name]=t.value;return a}},t}();"object"==typeof exports&&exports&&(exports.HTMLParser=HTMLParser),HTMLHint.addRule({id:"attr-lowercase",description:"Attribute name must be lowercase.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i=e.attrs,r=e.col+e.tagName.length+1,s=0,o=i.length;o>s;s++){n=i[s];var l=n.name;l!==l.toLowerCase()&&t.error("Attribute name [ "+l+" ] must be lower case.",e.line,r+n.index,a,n.raw)}})}}),HTMLHint.addRule({id:"attr-no-duplication",description:"Attribute name can not been duplication.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i,r=e.attrs,s=e.col+e.tagName.length+1,o={},l=0,d=r.length;d>l;l++)n=r[l],i=n.name,o[i]===!0&&t.error("The name of attribute [ "+n.name+" ] been duplication.",e.line,s+n.index,a,n.raw),o[i]=!0})}}),HTMLHint.addRule({id:"attr-value-double-quotes",description:"Attribute value must closed by double quotes.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i=e.attrs,r=e.col+e.tagName.length+1,s=0,o=i.length;o>s;s++)n=i[s],(""!==n.value&&'"'!==n.quote||""===n.value&&"'"===n.quote)&&t.error("The value of attribute [ "+n.name+" ] must closed by double quotes.",e.line,r+n.index,a,n.raw)})}}),HTMLHint.addRule({id:"attr-value-not-empty",description:"Attribute must set value.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i=e.attrs,r=e.col+e.tagName.length+1,s=0,o=i.length;o>s;s++)n=i[s],""===n.quote&&""===n.value&&t.warn("The attribute [ "+n.name+" ] must set value.",e.line,r+n.index,a,n.raw)})}}),HTMLHint.addRule({id:"csslint",description:"Scan css with csslint.",init:function(e,t,a){var n=this;e.addListener("cdata",function(e){if("style"===e.tagName.toLowerCase()){var i;if(i="object"==typeof exports&&require?require("csslint").CSSLint.verify:CSSLint.verify,void 0!==a){var r=e.line-1,s=e.col-1;try{var o=i(e.raw,a).messages;o.forEach(function(e){var a=e.line;t["warning"===e.type?"warn":"error"]("["+e.rule.id+"] "+e.message,r+a,(1===a?s:0)+e.col,n,e.evidence)})}catch(l){}}}})}}),HTMLHint.addRule({id:"doctype-first",description:"Doctype must be first.",init:function(e,t){var a=this,n=function(i){"start"===i.type||"text"===i.type&&/^\s*$/.test(i.raw)||(("comment"!==i.type&&i.long===!1||/^DOCTYPE\s+/i.test(i.content)===!1)&&t.error("Doctype must be first.",i.line,i.col,a,i.raw),e.removeListener("all",n))};e.addListener("all",n)}}),HTMLHint.addRule({id:"doctype-html5",description:"Doctype must be html5.",init:function(e,t){function a(e){e.long===!1&&"doctype html"!==e.content.toLowerCase()&&t.warn("Doctype must be html5.",e.line,e.col,i,e.raw)}function n(){e.removeListener("comment",a),e.removeListener("tagstart",n)}var i=this;e.addListener("all",a),e.addListener("tagstart",n)}}),HTMLHint.addRule({id:"head-script-disabled",description:"The script tag can not be used in head.",init:function(e,t){function a(e){"script"===e.tagName.toLowerCase()&&t.warn("The script tag can not be used in head.",e.line,e.col,i,e.raw)}function n(t){"head"===t.tagName.toLowerCase()&&(e.removeListener("tagstart",a),e.removeListener("tagstart",n))}var i=this;e.addListener("tagstart",a),e.addListener("tagend",n)}}),HTMLHint.addRule({id:"href-abs-or-rel",description:"Href must be absolute or relative.",init:function(e,t,a){var n=this,i="abs"===a?"absolute":"relative";e.addListener("tagstart",function(e){for(var a,r=e.attrs,s=e.col+e.tagName.length+1,o=0,l=r.length;l>o;o++)if(a=r[o],"href"===a.name){("absolute"===i&&/^\w+?:/.test(a.value)===!1||"relative"===i&&/^https?:\/\//.test(a.value)===!0)&&t.error("The value of href [ "+a.value+" ] must be "+i+".",e.line,s+a.index,n,a.raw);break}})}}),HTMLHint.addRule({id:"id-class-ad-disabled",description:"Id and class can not use ad keyword, it will blocked by adblock software.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i,r=e.attrs,s=e.col+e.tagName.length+1,o=0,l=r.length;l>o;o++)n=r[o],i=n.name,/^(id|class)$/i.test(i)&&/(^|[-\_])ad([-\_]|$)/i.test(n.value)&&t.warn("The value of "+i+" can not use ad keyword.",e.line,s+n.index,a,n.raw)})}}),HTMLHint.addRule({id:"id-class-value",description:"Id and class value must meet some rules.",init:function(e,t,a){var n,i=this,r={underline:{regId:/^[a-z\d]+(_[a-z\d]+)*$/,message:"Id and class value must lower case and split by underline."},dash:{regId:/^[a-z\d]+(-[a-z\d]+)*$/,message:"Id and class value must lower case and split by dash."},hump:{regId:/^[a-z][a-zA-Z\d]*([A-Z][a-zA-Z\d]*)*$/,message:"Id and class value must meet hump style."}};if(n="string"==typeof a?r[a]:a,n&&n.regId){var s=n.regId,o=n.message;e.addListener("tagstart",function(e){for(var a,n=e.attrs,r=e.col+e.tagName.length+1,l=0,d=n.length;d>l;l++)if(a=n[l],"id"===a.name.toLowerCase()&&s.test(a.value)===!1&&t.warn(o,e.line,r+a.index,i,a.raw),"class"===a.name.toLowerCase())for(var c,u=a.value.split(/\s+/g),f=0,g=u.length;g>f;f++)c=u[f],c&&s.test(c)===!1&&t.warn(o,e.line,r+a.index,i,c)})}}}),HTMLHint.addRule({id:"id-unique",description:"Id must be unique.",init:function(e,t){var a=this,n={};e.addListener("tagstart",function(e){for(var i,r,s=e.attrs,o=e.col+e.tagName.length+1,l=0,d=s.length;d>l;l++)if(i=s[l],"id"===i.name.toLowerCase()){r=i.value,r&&(void 0===n[r]?n[r]=1:n[r]++,n[r]>1&&t.error("Id redefinition of [ "+r+" ].",e.line,o+i.index,a,i.raw));break}})}}),HTMLHint.addRule({id:"img-alt-require",description:"Alt of img tag must be set value.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){if("img"===e.tagName.toLowerCase()){for(var n=e.attrs,i=!1,r=0,s=n.length;s>r;r++)if("alt"===n[r].name.toLowerCase()){i=!0;break}i===!1&&t.warn("Alt of img tag must be set value.",e.line,e.col,a,e.raw)}})}}),HTMLHint.addRule({id:"jshint",description:"Scan script with jshint.",init:function(e,t,a){var n=this;e.addListener("cdata",function(i){if("script"===i.tagName.toLowerCase()){var r=e.getMapAttrs(i.attrs),s=r.type;if(void 0!==r.src||s&&/^(text\/javascript)$/i.test(s)===!1)return;var o;if(o="object"==typeof exports&&require?require("jshint").JSHINT:JSHINT,void 0!==a){var l=i.line-1,d=i.col-1,c=i.raw.replace(/\t/g," ");try{var u=o(c,a);u===!1&&o.errors.forEach(function(e){var a=e.line;t.warn(e.reason,l+a,(1===a?d:0)+e.character,n,e.evidence)})}catch(f){}}}})}}),HTMLHint.addRule({id:"space-tab-mixed-disabled",description:"Spaces and tabs can not mixed in front of line.",init:function(e,t){var a=this;e.addListener("text",function(n){for(var i,r=n.raw,s=/(^|\r?\n)( +\t|\t+ )/g;i=s.exec(r);){var o=e.fixPos(n,i.index+i[1].length);t.warn("Mixed spaces and tabs in front of line.",o.line,1,a,n.raw)}})}}),HTMLHint.addRule({id:"spec-char-escape",description:"Special characters must be escaped.",init:function(e,t){var a=this;e.addListener("text",function(n){for(var i,r=n.raw,s=/[<>]/g;i=s.exec(r);){var o=e.fixPos(n,i.index);t.error("Special characters must be escaped : [ "+i[0]+" ].",o.line,o.col,a,n.raw)}})}}),HTMLHint.addRule({id:"src-not-empty",description:"Src of img(script,link) must set value.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){for(var n,i=e.tagName,r=e.attrs,s=e.col+i.length+1,o=0,l=r.length;l>o;o++)n=r[o],(/^(img|script|embed|bgsound|iframe)$/.test(i)===!0&&"src"===n.name||"link"===i&&"href"===n.name||"object"===i&&"data"===n.name)&&""===n.value&&t.error("[ "+n.name+"] of [ "+i+" ] must set value.",e.line,s+n.index,a,n.raw)})}}),HTMLHint.addRule({id:"style-disabled",description:"Style tag can not be use.",init:function(e,t){var a=this;e.addListener("tagstart",function(e){"style"===e.tagName.toLowerCase()&&t.warn("Style tag can not be use.",e.line,e.col,a,e.raw)})}}),HTMLHint.addRule({id:"tag-pair",description:"Tag must be paired.",init:function(e,t){var a=this,n=[],i=e.makeMap("area,base,basefont,br,col,frame,hr,img,input,isindex,link,meta,param,embed");e.addListener("tagstart",function(e){var t=e.tagName.toLowerCase();void 0!==i[t]||e.close||n.push(t)}),e.addListener("tagend",function(e){for(var i=e.tagName.toLowerCase(),r=n.length-1;r>=0&&n[r]!==i;r--);if(r>=0){for(var s=[],o=n.length-1;o>r;o--)s.push("");s.length>0&&t.error("Tag must be paired, Missing: [ "+s.join("")+" ]",e.line,e.col,a,e.raw),n.length=r}else t.error("Tag must be paired, No start tag: [ "+e.raw+" ]",e.line,e.col,a,e.raw)}),e.addListener("end",function(e){for(var i=[],r=n.length-1;r>=0;r--)i.push("");i.length>0&&t.error("Tag must be paired, Missing: [ "+i.join("")+" ]",e.line,e.col,a,"")})}}),HTMLHint.addRule({id:"tag-self-close",description:"The empty tag must closed by self.",init:function(e,t){var a=this,n=e.makeMap("area,base,basefont,br,col,frame,hr,img,input,isindex,link,meta,param,embed");e.addListener("tagstart",function(e){var i=e.tagName.toLowerCase();void 0!==n[i]&&(e.close||t.warn("The empty tag : [ "+i+" ] must closed by self.",e.line,e.col,a,e.raw))})}}),HTMLHint.addRule({id:"tagname-lowercase",description:"Tagname must be lowercase.",init:function(e,t){var a=this;e.addListener("tagstart,tagend",function(e){var n=e.tagName;n!==n.toLowerCase()&&t.error("Tagname [ "+n+" ] must be lower case.",e.line,e.col,a,e.raw)})}}); \ No newline at end of file diff --git a/src/core.js b/src/core.js index ee7068c37..be3ef6cb1 100644 --- a/src/core.js +++ b/src/core.js @@ -27,12 +27,13 @@ var HTMLHint = (function (undefined) { HTMLHint.rules[rule.id] = rule; }; - HTMLHint.verify = function(html, newRuleset){ + HTMLHint.verify = function(html, ruleset){ var id; - var ruleset; // parse inline ruleset html = html.replace(/^\s*/i, function(all, strRuleset){ - ruleset = {}; + if(ruleset === undefined){ + ruleset = {}; + } strRuleset.replace(/(?:^|,)\s*([^:]+)\s*:\s*([^,\s]+)/g, function(all, key, value){ if(value === 'false'){ value = false; @@ -44,12 +45,6 @@ var HTMLHint = (function (undefined) { }); return ''; }); - if(newRuleset !== undefined){ - ruleset = ruleset || {}; - for (id in newRuleset){ - ruleset[id] = newRuleset[id]; - } - } if(ruleset === undefined){ ruleset = HTMLHint.defaultRuleset; } diff --git a/test/core-spec.js b/test/core-spec.js index 868d88903..74a08ff07 100644 --- a/test/core-spec.js +++ b/test/core-spec.js @@ -17,15 +17,17 @@ describe('Core', function(){ it('Inline ruleset not worked should result in an error', function(){ var code = '\r\n'; - var messages = HTMLHint.verify(code); + var messages = HTMLHint.verify(code, { + 'img-alt-require': false + }); expect(messages.length).to.be(1); expect(messages[0].rule.id).to.be('img-alt-require'); expect(messages[0].line).to.be(2); expect(messages[0].col).to.be(1); - // overwrite inline ruleset + code = '\r\n'; messages = HTMLHint.verify(code, { - 'img-alt-require': false + 'img-alt-require': true }); expect(messages.length).to.be(0); });