Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn the user about bad CHDs #18803

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Warn the user about bad CHDs #18803

merged 2 commits into from
Jan 31, 2024

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jan 31, 2024

If they're not created with "chdman createdvd", they will perform really badly.

See #18798

Sorry @TotalCaesar659 and @Saramagrean , another string for you :)

image

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Jan 31, 2024
@hrydgard hrydgard added this to the 1.17.1 milestone Jan 31, 2024
If they're not created with "chdman createdvd", they will perform really
badly.
@hrydgard hrydgard merged commit af20992 into master Jan 31, 2024
18 checks passed
@hrydgard hrydgard deleted the bad-chd-warning branch January 31, 2024 23:38
@TotalCaesar659
Copy link
Contributor

It's alright, I'm already used to it ;-)

@nameless1
Copy link

nameless1 commented Feb 6, 2024

So, it warns about bad chds that were made with createdvd... am I missing something?

E:\Playstation Portable\PSP Backups>chdman.exe info -i "Ape Escape on the Loose (USA).chd"
chdman - MAME Compressed Hunks of Data (CHD) manager 0.262 (unknown)
Input file: Ape Escape on the Loose (USA).chd
File Version: 5
Logical size: 749,240,320 bytes
Hunk Size: 4,096 bytes
Total Hunks: 182,920
Unit Size: 2,048 bytes
Total Units: 365,840
Compression: lzma (LZMA), zlib (Deflate), huff (Huffman), flac (FLAC)
CHD size: 279,415,049 bytes
Ratio: 37.3%
SHA1: aabdebdb87d0363c4ba911dc72819dc5e014ad95
Data SHA1: 373098a849dcdc573499a28c89c92b63376e666d
Metadata: Tag='DVD ' Index=0 Length=1 bytes

Screenshot 2024-02-05 220959

Edit: Looks like it might be the updated hunksize in the test build of chdman, tried an older verson of a chd produced before 2.62 and no label...

Edit 2: It's defiantly hunksize in the test version, lowering it to 2048 (i.e. original hunksize) clears the warning... and this version of chdman wont be stable till the end of february... so just an fyi I guess.

@hrydgard
Copy link
Owner Author

hrydgard commented Feb 6, 2024

Yup it's the hunk size. No other hunk size than 2048 makes sense to use, since that's the sector size.

@pocafon
Copy link

pocafon commented Feb 14, 2024

How can we lower the hunk size to 2048 if it's not much to ask?

@hrydgard
Copy link
Owner Author

@pocafon using chdman createdvd will do it automatically.

You need a recent build of chdman though, such as the one shipped with the latest build of MAME.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants