More crashfix/leakfix attempts #18243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
assorted-fixes-11
branch
from
fb93bed
to
f2cfbe1
Compare
hrydgard
force-pushed
the
assorted-fixes-11
branch
from
bec0ca3
to
42fcd39
Compare
unknownbrackets
approved these changes
Sep 26, 2023
| @@ -521,7 +521,7 @@ void TessellationDataTransferGLES::SendDataToShader(const SimpleVertex *const *p | |||
| if (prevSizeU < size_u || prevSizeV < size_v) { | |||
| prevSizeU = size_u; | |||
| prevSizeV = size_v; | |||
| if (!data_tex[0]) | |||
| if (data_tex[0]) | |||
| renderManager_->DeleteTexture(data_tex[0]); | |||
There was a problem hiding this comment.
Looks like my mistake in #16078, not quite that old. Oops.
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to solve even more stuff seen in crash reports and in the mystery thread #18116 .
This includes a fix for a bizarre bug in OpenGL hardware tessellation where we were rapidly leaking texture data..