Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL: support HiDPI on wayland #17651

Merged
merged 2 commits into from
Jul 2, 2023
Merged

SDL: support HiDPI on wayland #17651

merged 2 commits into from
Jul 2, 2023

Conversation

hch12907
Copy link
Contributor

Not sure if this is correct, I am familiar with neither SDL nor the codebase of PPSSPP. Tested on X11 and Wayland though, both seem to work just like before.

@hrydgard
Copy link
Owner

Cool, I'm gonna test on my Linux laptop where I had some DPI issues soon.

@hrydgard hrydgard added this to the v1.16.0 milestone Jun 30, 2023
@hrydgard hrydgard added the SDL2 Issue on SDL (or Qt in SDL code) but not all ports. label Jun 30, 2023
@hrydgard
Copy link
Owner

hrydgard commented Jul 2, 2023

It doesn't help the weird DPI I'm getting, but also it doesn't break anything. Let's get it in.

@hrydgard hrydgard merged commit 1253e60 into hrydgard:master Jul 2, 2023
@hrydgard
Copy link
Owner

hrydgard commented Jul 4, 2023

Hm, this somehow made things gigantic on OSX, so gonna have to add some checks, or figure out what's going on..

@hrydgard
Copy link
Owner

hrydgard commented Jul 4, 2023

Actually, I'm going to revert this. It's clearly not tested enough. For example, on OSX, you get a different rendered DPI after the first window resize, plus it's wrong.

hrydgard added a commit that referenced this pull request Jul 4, 2023
This reverts commit 1253e60, reversing
changes made to adc24b5.
@hch12907
Copy link
Contributor Author

hch12907 commented Jul 5, 2023

That's a bummer, because I don't have a MacOS machine to test the code on :/

I suspect the problem is on the preprocessor condition in UpdateScreenScale() though.

@hrydgard
Copy link
Owner

hrydgard commented Jul 5, 2023

I may resurrect and debug this myself on Mac in the near future, I just didn't want to leave it in such a broken state. That's probably a good place to start looking yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDL2 Issue on SDL (or Qt in SDL code) but not all ports.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants