-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL: support HiDPI on wayland #17651
Conversation
Cool, I'm gonna test on my Linux laptop where I had some DPI issues soon. |
It doesn't help the weird DPI I'm getting, but also it doesn't break anything. Let's get it in. |
Hm, this somehow made things gigantic on OSX, so gonna have to add some checks, or figure out what's going on.. |
Actually, I'm going to revert this. It's clearly not tested enough. For example, on OSX, you get a different rendered DPI after the first window resize, plus it's wrong. |
That's a bummer, because I don't have a MacOS machine to test the code on :/ I suspect the problem is on the preprocessor condition in UpdateScreenScale() though. |
I may resurrect and debug this myself on Mac in the near future, I just didn't want to leave it in such a broken state. That's probably a good place to start looking yeah. |
Not sure if this is correct, I am familiar with neither SDL nor the codebase of PPSSPP. Tested on X11 and Wayland though, both seem to work just like before.