Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add linux launcher category to electron-builder config #240

Merged
merged 6 commits into from Mar 3, 2018
Merged

add linux launcher category to electron-builder config #240

merged 6 commits into from Mar 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2018

Fix for the following:

  • cannot map macOS category to Linux. If possible mapping is known for you, please file issue to add it. macCategory=public.app-category.business
  • application Linux category is set to default "Utility" reason=linux.category is not set and cannot map from macOS docs=https://electron.build/configuration/configuration#LinuxBuildOptions-category

@hql287 hql287 added this to the Build 06 - v1.1.4 milestone Mar 2, 2018
@hql287
Copy link
Owner

hql287 commented Mar 2, 2018 •
edited
Loading

@jens-t: This is an issue with electron-builder (when you run yarn release), right?

@ghost
Copy link
Author

ghost commented Mar 2, 2018

Yes, it's just a warning but it's nice to have the right category set.

@hql287 hql287 assigned hql287 and ghost and unassigned hql287 Mar 3, 2018
@hql287 hql287 merged commit 439873d into hql287:dev Mar 3, 2018
@ghost ghost deleted the linux-launcher-category branch March 3, 2018 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Build 06 - v1.1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@hql287 @jens-struct