-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate system Notification with autoUpdater #165
Comments
I forgot to say I got a beginning of a PR for this, basically you can disable/enable notifications in import OSNotification from 'app/helpers/notification'
OSNotifciation(title, body) Right now I am deciding whether to include the Manta Icon or the Company Icon you choose in |
Nice 👍. I think I already added the notification helper with this commit Maybe we can try to reuse/refactor it?
It should always be Manta's icon as at the OS level, the user only needs to know which application just sent the notification. And this is already taken cared of by Electron. Also, I noticed that there're a few helpers that we use across windows such as this one and the |
I didnt know about that commit 😮 I have never done anything preview related so have never looked inside the
Yes of course 🙂
Does the Manta icon appear by default when you get notified? When I try to run
Sure I can give it a try 🙂 |
The icon will only show up in production. It's how Electron works, not sure why though. If you really want to change the icon, you can try the Notification module, which only works in the main process. But in this case, I think using the HTML5 Notification API is enough.
👍 |
Show the notification once the download is completed.
The text was updated successfully, but these errors were encountered: