Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON feed loader #8

Closed
ai opened this issue Jul 22, 2023 · 4 comments · Fixed by #160
Closed

Add JSON feed loader #8

ai opened this issue Jul 22, 2023 · 4 comments · Fixed by #160
Assignees
Labels

Comments

@ai
Copy link
Contributor

ai commented Jul 22, 2023

We need to define loader and test for JSON feed format.

We should re-use as much code as possible between RSS/Atom/JSON loaders.

https://en.wikipedia.org/wiki/JSON_Feed

@ai ai moved this to Task Drafts in Slow Reader Tasks Mar 21, 2024
@ai ai removed this from Slow Reader Tasks Mar 23, 2024
@ai ai moved this to Ready to Take in Slow Reader Tasks Mar 26, 2024
@ai ai added the Core JS label Apr 2, 2024
@upteran
Copy link
Contributor

upteran commented Apr 8, 2024

Can I take this one ?

@ai
Copy link
Contributor Author

ai commented Apr 8, 2024

Sure!

@ai ai moved this from Ready to Take to In Progress in Slow Reader Tasks Apr 8, 2024
@upteran upteran mentioned this issue Apr 12, 2024
18 tasks
@upteran
Copy link
Contributor

upteran commented Apr 13, 2024

I encountered some cases during testing and want to clarify behavior.

Current behavior

Image

  • After the page is requested, each loader requests its own links and retrieves them.
  • As a result, we get pages with feedjson and rss content.
  • In the preview result list block, we can see a few items with the same name and content (one JSON, two rss+xml).

Image

Probably, when we call getLinksFromText in the preview and request all links, we add all responses to the result list. In the case where we load different content of one feed type, it's okay, but when we have different types with the same content, it looks like duplication. Is this correct behavior, or we should do something with it ?

@ai ai linked a pull request Apr 13, 2024 that will close this issue
18 tasks
@ai
Copy link
Contributor Author

ai commented Apr 13, 2024

In the case where we load different content of one feed type, it's okay, but when we have different types with the same content, it looks like duplication. Is this correct behavior, or we should do something with it ?

It is OK if user will see RSS, Atom, and FeedJSON feeds together.

It is a little confusing, but we will think about it later. Right now most of RSS readers shows all feeds and advanced users expect it.

But thanks of thinking for edge cases and beginners UX.

@ai ai closed this as completed in #160 Apr 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Wait for Deploy in Slow Reader Tasks Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Wait for Deploy
Development

Successfully merging a pull request may close this issue.

2 participants