Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installing docker-compose #114

Open
carolynvs opened this issue May 25, 2016 · 10 comments
Open

Support installing docker-compose #114

carolynvs opened this issue May 25, 2016 · 10 comments

Comments

@carolynvs
Copy link
Collaborator

carolynvs commented May 25, 2016

Would it be useful to have dvm also download the docker-compose client?

$ dvm install --compose 1.7.1
# downloads docker-compose to $DVM_DIR/bin/docker-compose/1.7.1/docker-compose

$ dvm use --compose 1.7.1
# adds the above directory to the path

It would be really neat to have dvm know which version of compose goes with a docker version. So that if you dvm use 1.10.1, the right version of docker-compose is also added to your path. No clue if that information is readily available though...

@rgbkrk
Copy link
Member

rgbkrk commented May 25, 2016

Docker compose is written in Python. I wouldn't go anywhere near that, as you'd have to rely on the user's python environment or a specialized local version.

@carolynvs
Copy link
Collaborator Author

@rgbkrk docker-compose is just a binary, distributed from their GitHub releases page similar to the docker client. What am I missing?

@rgbkrk
Copy link
Member

rgbkrk commented May 25, 2016

Whoa! That's changed up! It's still Python so they must be creating a bundled executable. Way cool!

@carolynvs
Copy link
Collaborator Author

@everett-toews @jamiehannaford Have you used docker-compose enough to know about how to match up a docker-compose version with a docker version? Is it just something you need to know from reading release notes?

@etoews
Copy link
Contributor

etoews commented May 26, 2016

@carolynvs Let's hold off on this until after DockerCon.

@jeffwidman
Copy link

jeffwidman commented May 29, 2016

Please make this optional, as I'd rather manage my docker-compose under python virtualenv's...

@carolynvs
Copy link
Collaborator Author

@jeffwidman Yup! If we did this, the default behavior of dvm would remain the same, and the capability to download compose would be controlled with an extra flag.

@carolynvs
Copy link
Collaborator Author

It looks to me like docker-compose isn't going away(?), based on the demos from the DockerCon keynote. I don't have time to add this right now anyway, but we'll see things look when I resurface in a month. 😄

@lifeiscontent
Copy link

@carolynvs any updates on this?

@carolynvs
Copy link
Collaborator Author

Not really, no. If you’d like to submit a PR adding support for docker-compose too I’d be happy to review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants