Hound suggests renaming unused method arguments

[georgebrock]

Hound suggests renaming unused method arguments, e.g.:

Unused method argument - job. If it's necessary, use _ or _job as an argument name to indicate that it won't be used.

This isn't in the thoughtbot Ruby style guide. The closest thing in the guides is for block parameters:

Use _ for unused block parameters.

[gylaz]

I opened a PR for this thoughtbot/guides#335.

[gylaz]

I'm thinking at the very least we want to be notified if a variable or argument is unused, because maybe someone forgot to remove it. Not sure if RuboCop supports a message to notify someone that something is unused.

[georgebrock]

There's a separate notification for an unused variable, and I agree that one makes sense. I'd also be happy with a “this argument is unused, did you mean to remove it?” notification. It's the “you should prefix this” part that I disagree with.

[gylaz]

This is now in the thoughtbot guides. Closing.