-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSG route called #3088
Comments
I'll look abt this |
hi @RobertSasak |
I run vite to command to produce static pages. ssgParams define only one page to be generated. It has id="shop1". However actual route get called twice. First time with a id=":id" and second time with id="shop1". Only one static page is actually produced on the disk(shop1.html). However during my test I also saw ":id.html" created on the disk. I am not sure how to reproduce it. |
hmm... |
Hi @RobertSasak This is a known issue. We may fix it. |
@watany-dev @sor4chi @nakasyou @usualoma Do you have any idea? |
Thank you for following up this issue. I don't think it is necessary to spend energy on it as there is a simple workaround for it. I expected it will be fixed onced the question whether SSG should be middleware or not. const id = c.req.param('id')
if (id==':id') {
return c.html('Ignored', 500) // https://github.com/honojs/hono/issues/3088
} |
When I implemented this, I couldn't find how to resolve this. However, application users can access |
I have an idea. What do you think about allowing |
What version of Hono are you using?
4.4.11
What runtime/platform is your app running on?
NodeJS
What steps can reproduce the bug?
What is the expected behavior?
It is expected to log
What do you see instead?
Additional information
Route is called twice instead of once. First time the route is called the parameter id is not replaced with the actual value but stays ":id".
I think it might be related to #2175
The text was updated successfully, but these errors were encountered: