Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question About Trace Flag Propagation in UnmarshalHoneyCombTraceContext and MarshalW3CTraceContext #453

Open
Flgado opened this issue Mar 4, 2025 · 0 comments
Labels
type: discussion Requests for comments, discussions about possible enhancements.

Comments

@Flgado
Copy link

Flgado commented Mar 4, 2025

Hi team,

I am trying to propagate tracing information from the Honeycomb header using UnmarshalHoneyCombTraceContext, followed by MarshalW3CTraceContext, and then passing it to OpenTelemetry (Otel).

I noticed that UnmarshalHoneyCombTraceContext correctly parses the trace_id, parent_id, and context, but it does not seem to parse or propagate the trace-flags. As a result, when MarshalW3CTraceContext processes the data, it does not receive the flag, preventing it from being forwarded to OpenTelemetry. Since OpenTelemetry relies on this flag, if using the default trace sampling, to determine whether a request should be traced, this behavior raises some questions.

Is this an intentional design decision, meaning that the propagation of the trace flag must be explicitly handled by developers? Or is this a missing feature in the library? Has anyone encountered this issue before?

Thanks :)

@Flgado Flgado added the type: discussion Requests for comments, discussions about possible enhancements. label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Requests for comments, discussions about possible enhancements.
Projects
None yet
Development

No branches or pull requests

1 participant