From d88e14364b439d71dd1256675c219752ba92f242 Mon Sep 17 00:00:00 2001
From: Nick Walker <nswalker@cs.washington.edu>
Date: Fri, 14 Aug 2020 15:12:20 -0700
Subject: [PATCH] Linter updates for YOLO

Fix whitespace, disable roslint
---
 .flake8                     | 2 +-
 .github/workflows/ci.yaml   | 1 +
 uw_detection/CMakeLists.txt | 1 -
 uw_detection/package.xml    | 1 -
 uw_detection/setup.py       | 2 +-
 5 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/.flake8 b/.flake8
index 1d0f20d..7877ccc 100644
--- a/.flake8
+++ b/.flake8
@@ -1,6 +1,6 @@
 [flake8]
 max-line-length = 160
-exclude = tests/*
+exclude = tests/* uw_detection/src/yolov3
 max-complexity = 10
 # We import modules here to make the API cleaner
 per-file-ignores = **/recognize_speech/__init__.py:F401
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 5e98ea5..0cf493d 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -7,6 +7,7 @@ jobs:
     env:
       AFTER_SCRIPT: 'cd $target_ws && rosenv && catkin build $(catkin list --depends-on roslint -u) --no-deps --no-status --verbose --make-args roslint'
       CATKIN_LINT: true
+      CATKIN_LINT_ARGS: "--ignore missing_directory --ignore external_link_directory"
       ROS_DISTRO: melodic
       ROS_REPO: main
     strategy:
diff --git a/uw_detection/CMakeLists.txt b/uw_detection/CMakeLists.txt
index 59889f2..836d796 100644
--- a/uw_detection/CMakeLists.txt
+++ b/uw_detection/CMakeLists.txt
@@ -9,7 +9,6 @@ find_package(catkin REQUIRED COMPONENTS
         message_filters
         message_runtime
         roscpp
-        roslint
         sensor_msgs
         std_msgs
         std_srvs
diff --git a/uw_detection/package.xml b/uw_detection/package.xml
index 57d5bef..772408d 100644
--- a/uw_detection/package.xml
+++ b/uw_detection/package.xml
@@ -25,7 +25,6 @@
 
   <build_depend>image_transport</build_depend>
   <build_depend>octomap</build_depend>
-  <build_depend>roslint</build_depend>
   <build_depend>std_srvs</build_depend>
   <build_depend>tf2</build_depend>
   <build_depend>tf2_eigen</build_depend>
diff --git a/uw_detection/setup.py b/uw_detection/setup.py
index 81d0f8c..756d253 100644
--- a/uw_detection/setup.py
+++ b/uw_detection/setup.py
@@ -8,4 +8,4 @@
     packages=['yolov3'],
     package_dir={'': 'src'})
 
-setup(**setup_args)
\ No newline at end of file
+setup(**setup_args)