Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification Request: homebridge-Reolink Siren & Light through Nvr #784

Open
KuyaPollio opened this issue Nov 15, 2024 · 10 comments
Open

Verification Request: homebridge-Reolink Siren & Light through Nvr #784

KuyaPollio opened this issue Nov 15, 2024 · 10 comments
Labels
awaiting-changes use after review has started - awaiting user to make changes to plugin request-verification

Comments

@KuyaPollio
Copy link

KuyaPollio commented Nov 15, 2024

Plugin Name

@drpollio/homebridge-reolink-camera-siren-and-light-nvr

Link To GitHub Repo

https://github.com/KuyaPollio/homebridge-reolink-siren#readme

Plugin Icon (Optional)

No response

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟢 Yes

The plugin successfully installs and does not start unless it is configured.

🟢 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟢 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟢 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟢 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟢 Yes

More Information

No response

@KuyaPollio KuyaPollio added pending the label given to a new verification/icon request request-verification labels Nov 15, 2024
Copy link

🔴 The following checks failed:

  • JSON results file not found

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Nov 15, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale used for stale issues label Dec 16, 2024
Copy link

This issue has been closed as no further activity has occurred.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2024
@bwp91 bwp91 reopened this Dec 29, 2024
@KuyaPollio
Copy link
Author

Any information on what is blocking the verification ?

@bwp91
Copy link
Contributor

bwp91 commented Dec 29, 2024

/check

@github-actions github-actions bot added pending the label given to a new verification/icon request and removed awaiting-changes use after review has started - awaiting user to make changes to plugin labels Dec 29, 2024
Copy link

🔴 The following checks failed:

  • JSON results file not found

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

These checks were run against v of the plugin.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Dec 29, 2024
@bwp91
Copy link
Contributor

bwp91 commented Dec 29, 2024

/check

@github-actions github-actions bot added pending the label given to a new verification/icon request and removed awaiting-changes use after review has started - awaiting user to make changes to plugin labels Dec 29, 2024
Copy link

🔴 The following checks failed:

  • Package JSON: engines.node property is not compatible with Node 18
  • Package JSON: engines.node property is not compatible with Node 22
  • GitHub Repo: should have issues enabled
  • GitHub Repo: should contain releases
  • Config Schema JSON: does not contain a name schema property

🟢 The following checks passed:

  • Installation: successfully installed
  • Package JSON: homepage exists
  • Package JSON: bugs.url exists and seems a valid URL
  • Package JSON: keywords exist and contain 'homebridge-plugin'
  • Package JSON: 'preinstall' in scripts is not present
  • Package JSON: 'install' in scripts is not present
  • Package JSON: 'postinstall' in scripts is not present
  • Package JSON: engines.node property is compatible with Node 20
  • Package JSON: engines.homebridge property is compatible with Homebridge 1.8.5
  • Package JSON: initializer function found
  • GitHub Repo: repository is public
  • GitHub Repo: repository is not archived
  • NPM Package: has not been deprecated
  • Config Schema JSON: exists and is valid JSON
  • Config Schema JSON: contains a valid pluginAlias
  • Config Schema JSON: the pluginType is set to 'platform'
  • Dependencies: homebridge was not installed as a dependency
  • Dependencies: hap-nodejs was not installed as a dependency

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

These checks were run against v1.1.3 of the plugin.

@github-actions github-actions bot added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels Dec 29, 2024
@bwp91
Copy link
Contributor

bwp91 commented Dec 29, 2024

@KuyaPollio see the above comment ^

@bwp91 bwp91 removed the stale used for stale issues label Dec 29, 2024
@KuyaPollio
Copy link
Author

Thanks you very much i'll make the changes asap 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes use after review has started - awaiting user to make changes to plugin request-verification
Projects
None yet
Development

No branches or pull requests

2 participants