Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebridge-airtouch5-platform #580

Closed
cemilbrowne opened this issue Oct 23, 2023 · 18 comments
Closed

homebridge-airtouch5-platform #580

cemilbrowne opened this issue Oct 23, 2023 · 18 comments
Labels
verified use when a plugin meets the criteria - adds the verified badge text

Comments

@cemilbrowne
Copy link

Link To GitHub Repo

https://github.com/cemilbrowne/homebridge-airtouch5-platform

Link To NPM Package

https://www.npmjs.com/package/homebridge-airtouch5-platform

@cemilbrowne cemilbrowne added the pending the label given to a new verification/icon request label Oct 23, 2023
@github-actions
Copy link

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-airtouch5-platform -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

@cemilbrowne
Copy link
Author

/check

@github-actions
Copy link

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-airtouch5-platform -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

@cemilbrowne
Copy link
Author

/check

@github-actions
Copy link

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-airtouch5-platform -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

@cemilbrowne
Copy link
Author

/check

@github-actions
Copy link

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-airtouch5-platform -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

@cemilbrowne
Copy link
Author

/check

@github-actions
Copy link

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-airtouch5-platform -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

@bwp91
Copy link
Contributor

bwp91 commented Oct 25, 2023

/check

@github-actions
Copy link

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-airtouch5-platform -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

@bwp91
Copy link
Contributor

bwp91 commented Oct 27, 2023

/check

@github-actions
Copy link

✅ Pre-checks completed successfully.

@bwp91 bwp91 added the reviewed label Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

  • - The plugin must successfully install.
  • - The plugin must implement the Homebridge Plugin Settings GUI.
  • - The plugin must not start unless it is configured.
  • - The plugin must be of type dynamic platform.
  • - The plugin must not offer the same nor less functionality than that of any existing verified plugin.
  • - The plugin must not execute post-install scripts that modify the user's system in any way.
  • - The plugin must not contain any analytics or calls that enable you to track the user.
  • - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
  • - The plugin must be published to npm and the source code available on GitHub.
  • - A GitHub release should be created for every new version of your plugin, with patch notes.
  • - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node v18 and v20.
  • - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

Everything Looks Good!

@bwp91
Copy link
Contributor

bwp91 commented Nov 1, 2023

Hi @cemilbrowne

All in all looks good, I have a couple of follow-up comments:


You should add some keywords here for your plugin:


I think you should sync your GitHub release titles with the version number that you are releasing to npm at the time.

For example, if you are releasing 1.7.0 to npm then the corresponding github release title should be v1.7.0.

This is how the homebridge UI is able to show release notes before a user updates the plugin.


When I installed and saw this screen, I didn't know what a 'unit' was. Im assuming that any user that would genuinely need this plugin would understand what this meant. So whether or not it needs further explanation? 🤷‍♂️

Screenshot 2023-11-01 at 20 32 05

@bwp91 bwp91 added verified use when a plugin meets the criteria - adds the verified badge text and removed pending the label given to a new verification/icon request reviewed labels Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Congratulations! Your plugin has been verified.

You can now add one of the Verified by Homebridge badges to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

verified-by-homebridge

[![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

@bwp91
Copy link
Contributor

bwp91 commented Nov 1, 2023

Anyway, nice work, thanks for your contribution to the homebridge community 👍

Will close this issue now since i have verified the plugin, please feel free to reply with any comments/questions etc,

@bwp91 bwp91 closed this as completed Nov 1, 2023
@cemilbrowne
Copy link
Author

Great; thank you for the feedback - I'll action. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified use when a plugin meets the criteria - adds the verified badge text
Projects
None yet
Development

No branches or pull requests

2 participants