-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homebridge-airtouch5-platform #580
Comments
The following pre-checks failed: ❌ Failed to test plugin. Comment |
/check |
The following pre-checks failed: ❌ Failed to test plugin. Comment |
/check |
The following pre-checks failed: ❌ Failed to test plugin. Comment |
/check |
The following pre-checks failed: ❌ Failed to test plugin. Comment |
/check |
The following pre-checks failed: ❌ Failed to test plugin. Comment |
/check |
The following pre-checks failed: ❌ Failed to test plugin. Comment |
/check |
✅ Pre-checks completed successfully. |
Everything Looks Good! |
Hi @cemilbrowne All in all looks good, I have a couple of follow-up comments: You should add some keywords here for your plugin: I think you should sync your GitHub release titles with the version number that you are releasing to npm at the time. For example, if you are releasing This is how the homebridge UI is able to show release notes before a user updates the plugin. When I installed and saw this screen, I didn't know what a 'unit' was. Im assuming that any user that would genuinely need this plugin would understand what this meant. So whether or not it needs further explanation? 🤷♂️ |
Congratulations! Your plugin has been verified. You can now add one of the Verified by Homebridge badges to your plugin's README:
Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions. If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along. Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel! Thank you for your contribution to the Homebridge Community. |
Anyway, nice work, thanks for your contribution to the homebridge community 👍 Will close this issue now since i have verified the plugin, please feel free to reply with any comments/questions etc, |
Great; thank you for the feedback - I'll action. Much appreciated. |
Link To GitHub Repo
https://github.com/cemilbrowne/homebridge-airtouch5-platform
Link To NPM Package
https://www.npmjs.com/package/homebridge-airtouch5-platform
The text was updated successfully, but these errors were encountered: