Skip to content

Fix recorder does not vacuum SQLite DB on purge#9469

Merged
pvizeli merged 1 commit into
home-assistant:devfrom
milanvo:fix-recorder
Sep 17, 2017
Merged

Fix recorder does not vacuum SQLite DB on purge#9469
pvizeli merged 1 commit into
home-assistant:devfrom
milanvo:fix-recorder

Conversation

@milanvo
Copy link
Copy Markdown
Contributor

@milanvo milanvo commented Sep 17, 2017

Description:

Fixes incorrect IF condition in purge operation for SQLite sqlalchemy driver. Vacuum does not work, because different driver name.

Related issue (if applicable): fixes #9441

Pull request in home-assistant.github.io with documentation (if applicable): n/a

Checklist:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @milanvo,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Copy Markdown
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvizeli pvizeli merged commit 2219dca into home-assistant:dev Sep 17, 2017
@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Sep 17, 2017

Thanks for fix

@balloob balloob mentioned this pull request Sep 22, 2017
@milanvo milanvo deleted the fix-recorder branch October 4, 2017 13:46
@home-assistant home-assistant locked and limited conversation to collaborators Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: recorder component does not Vacuum SQLite DB on purge

3 participants