Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'monitored_conditions' optional #8848

Merged
merged 2 commits into from
Aug 6, 2017
Merged

Make 'monitored_conditions' optional #8848

merged 2 commits into from
Aug 6, 2017

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Aug 5, 2017

Description:

  • Do not call update() in constructor
  • Make monitored_conditions optional
  • Update ordering

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3142

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: sonarr
    api_key: !secret sonarr_api

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@fabaff fabaff merged commit 058deb5 into dev Aug 6, 2017
@fabaff fabaff deleted the update-sonarr branch August 6, 2017 08:07
@fabaff fabaff mentioned this pull request Aug 12, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
* Do not call update() in constructor

* Update tests
@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants