LIFX: Move light effects to external library#8222
Merged
Merged
Conversation
This moves the LIFX light effects to the external library aiolifx_effects. To get the light state synchronized between that library and HA, the LIFX platform no longer maintains the light state itself. Instead, it uses the cached state that aiolifx maintains. The reorganization also includes the addition of a cleanup handler.
|
@amelchio, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @arsaboo and @shmuelzon to be potential reviewers. |
houndci-bot
reviewed
Jun 26, 2017
| hsbk = [hue, saturation, brightness, kelvin] | ||
| return None if hsbk == [None]*4 else hsbk | ||
|
|
||
| def merge_hsbk(base, change): |
|
|
||
| return True | ||
|
|
||
| def find_hsbk(**kwargs): |
Member
|
Awesome! 🐬 |
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* LIFX: Move light effects to external library This moves the LIFX light effects to the external library aiolifx_effects. To get the light state synchronized between that library and HA, the LIFX platform no longer maintains the light state itself. Instead, it uses the cached state that aiolifx maintains. The reorganization also includes the addition of a cleanup handler. * Fix style
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This moves the LIFX light effect logic to the external library aiolifx_effects.
Breaking change note: The
lifx_effect_breathecall was deprecated in version 0.47 and has now been removed. You can uselifx_effect_pulsewithmode: breathefor the same effect.Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully.REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.