Skip to content

Added invert flag for position for actuators with inverted position#8147

Merged
pvizeli merged 1 commit into
devfrom
unknown repository
Jun 22, 2017
Merged

Added invert flag for position for actuators with inverted position#8147
pvizeli merged 1 commit into
devfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 22, 2017

Description:

Some shutter actuators have an inverted position indication compared to Home assistant. In this case, 100% means "closed" and 0% "open". The invert option allows to

Related issue (if applicable): None

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

cover:
  platform: knx
  name: Shutter
  updown_address: 1/140
  stop_address: 1/141
  setposition_address: 1/142
  getposition_address: 1/144
  invert_position: True

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@pvizeli pvizeli merged commit ca71d34 into home-assistant:dev Jun 22, 2017
@balloob balloob mentioned this pull request Jul 1, 2017
@ghost ghost deleted the knxcover2 branch July 20, 2017 11:52
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants