HomeMatic optimizations and code cleanup#7986
Merged
Merged
Conversation
houndci-bot
reviewed
Jun 9, 2017
| def _init_data_struct(self): | ||
| """Generate a data dict (self._data) from the Homematic metadata.""" | ||
| # Use STATE | ||
| """Generate the data dictionary (self._data) from the HomeMatic metadata.""" |
| def _init_data_struct(self): | ||
| """Generate a data struct (self._data) from the Homematic metadata.""" | ||
| # add state to data struct | ||
| """Generate the data dictionary (self._data) from the HomeMatic metadata.""" |
houndci-bot
reviewed
Jun 9, 2017
| self._data.update({self._state: STATE_UNKNOWN}) | ||
| else: | ||
| _LOGGER.critical("Can't correctly init sensor %s", self._name) | ||
| _LOGGER.critical("Can't correctly initialize sensor %s", self._name) |
houndci-bot
reviewed
Jun 9, 2017
| self._data.update({self._state: STATE_UNKNOWN}) | ||
| else: | ||
| _LOGGER.critical("Can't correctly init sensor %s", self._name) | ||
| _LOGGER.critical("Can't correctly initialize sensor %s", self._name) |
danielperna84
changed the title
Merged
ghost
removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Minor optimizations and some code cleanup. Especially getting rid of some unneeded debug-logs as requested by @pvizeli .
Looking good?