lock.sesame: Update pysesame, add state attributes#7953
Merged
Conversation
pvizeli
requested changes
Jun 8, 2017
Member
There was a problem hiding this comment.
You can cleanup your code and call the api direct without make propertys.
Contributor
Author
There was a problem hiding this comment.
OK, wasn't sure if there was a preference since I saw this in some platforms.
* Update pysesame requirement to 0.1.0 to support caching * Set `available` property based on API enabled status * Add state attributes for device ID and battery level
pvizeli
approved these changes
Jun 8, 2017
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update pysesame requirement to 0.1.0 to support caching
Set available property based on API enable status
Add state attributes for device ID and battery level
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py.