Skip to content

Change nad_receiver to pypi#7852

Merged
andrey-git merged 2 commits into
home-assistant:devfrom
joopert:dev
Jun 3, 2017
Merged

Change nad_receiver to pypi#7852
andrey-git merged 2 commits into
home-assistant:devfrom
joopert:dev

Conversation

@joopert
Copy link
Copy Markdown
Contributor

@joopert joopert commented Jun 1, 2017

Description:

Related issue (if applicable): #7069

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @joopert,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@mention-bot
Copy link
Copy Markdown

@joopert, thanks for your PR! By analyzing the history of the files in this pull request, we identified @infamy, @fabaff and @balloob to be potential reviewers.

@joopert joopert changed the title Change to pypi Change nad_receiver to pypi Jun 1, 2017
@balloob
Copy link
Copy Markdown
Member

balloob commented Jun 2, 2017

Please update requirements file by running script/gen_requirements_all.py as mentioned in the PR template.

@andrey-git andrey-git merged commit e50588a into home-assistant:dev Jun 3, 2017
@andrey-git
Copy link
Copy Markdown
Contributor

Thanks!

@balloob balloob mentioned this pull request Jun 16, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants