zoneminder: fix incorrect use of logging.exception.#7675
Merged
fabaff merged 1 commit intoMay 21, 2017
Conversation
Prior to this change the zoneminder component was attempting to use logging.exception outside of exception handling code. This would lead to the traceback module throwing an exception when trying to work out the traceback for the exception. This fixes the issue by changing the exception call into a plain error logging call.
tobygray
added a commit
to tobygray/home-assistant
that referenced
this pull request
May 27, 2017
This reverts the file permission changes introduced in: * home-assistant#7673 * home-assistant#7675
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Prior to this change the zoneminder component was attempting to
use logging.exception outside of exception handling code. This
would lead to the traceback module throwing an exception when
trying to work out the traceback for the exception.
This fixes the issue by changing the exception call into a
plain error logging call.
Related issue (if applicable): fixes #7674
Pull request in home-assistant.github.io with documentation (if applicable): No documentation change needed.
Example entry for
configuration.yaml(if applicable):No configuration change needed.
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.