Add password parameter to uvc component#7499
Merged
balloob merged 1 commit intoMay 10, 2017
Merged
Conversation
houndci-bot
reviewed
May 8, 2017
963447b to
7f4602d
Compare
houndci-bot
reviewed
May 8, 2017
There was a problem hiding this comment.
continuation line under-indented for visual indent
7f4602d to
ad75cb2
Compare
ad75cb2 to
d4e03f3
Compare
Contributor
|
This looks good to me. If |
Contributor
Author
It doesn't appear to be. It is specific to this python library and a google search reveals that is is largely undiscovered. In my opinion there is little benefit in supporting this file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue where the UVC component would not properly authenticate.
The uvcclient requires that the camera password is stored in a JSON file in
~/.uvcclientby default.The current integration Home Assistant is defaulting to the
ubntpassword but does not work for users that are using another password.I really don't see how this ever worked for users that changed the default
ubntpassword. It probably never did which is why so many users are reporting problems.This PR removes the "store" codepath and simply allows a
passwordargument to be passed for the component.Related issues:
Fixes #2979.
Fixes #7151.
Fixes #3810. (in my opinion)
Related community issues:
Pull request in home-assistant.github.io with documentation: home-assistant/home-assistant.io#2600
Example entry for
configuration.yaml:Checklist:
toxrun successfully.