Improve validation of device action config#27029
Merged
balloob merged 1 commit intoOct 2, 2019
Merged
Conversation
probot-home-assistant
Bot
added
core
has-tests
integration: automation
small-pr
balloob
reviewed
Oct 1, 2019
| """Validate config.""" | ||
| action_type = _determine_action(config) | ||
|
|
||
| if action_type == ACTION_DEVICE_AUTOMATION: |
Member
There was a problem hiding this comment.
Should we validate the other types?
Contributor
Author
There was a problem hiding this comment.
Not sure it's needed, other types are still validated through the action schema. We need to validate ACTION_CONDITION because it might include device conditions. That's coming in a follow up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Improve validation of device action config.
This includes action part from #26830
Improve both when loading at startup, and when an automation is modified through the automation editor UI.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: