UniFi - Try to handle when UniFi erroneously marks offline client as wired#26960
Merged
Kane610 merged 5 commits intoOct 2, 2019
Merged
Conversation
Kane610
force-pushed
the
unifi-handle-wireless-clients-becoming-wired
branch
from
239dcf0 to
cba069a
Compare
balloob
reviewed
Oct 1, 2019
balloob
reviewed
Oct 1, 2019
| def update_data(self, data, config_entry): | ||
| """Update data and schedule to save to file.""" | ||
| controller_id = get_controller_id_from_config_entry(config_entry) | ||
| self.data[controller_id] = list(data) |
Member
There was a problem hiding this comment.
Why would we not pass in a list already?
Member
Author
There was a problem hiding this comment.
data is a set from one specific controller containing all known wireless devices
balloob
reviewed
Oct 1, 2019
|
|
||
| def update_wireless_clients(self): | ||
| """Update set of known to be wireless clients.""" | ||
| wireless_clients = set() |
Member
There was a problem hiding this comment.
If you prefer sets, just convert it to sets when you load the data and convert it to lists when you save it.
Member
Author
There was a problem hiding this comment.
This is just a local list to know which new wireless clients we see from last update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Description:
There is an issue with UniFi that when the client goes offline that it is marked as wired and with a different time stamp, this makes it hard to use the client tracker since it will look like the client is at home. This makes some improvements toto handle not creating faulty POE control switches.
Related issue (if applicable): fixes #25915 #25893
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: