Skip to content

Revert Nest HVAC mode when disabling Eco mode#26934

Merged
pvizeli merged 1 commit into
home-assistant:devfrom
joe248:revert_hvac_mode
Sep 27, 2019
Merged

Revert Nest HVAC mode when disabling Eco mode#26934
pvizeli merged 1 commit into
home-assistant:devfrom
joe248:revert_hvac_mode

Conversation

@joe248
Copy link
Copy Markdown
Contributor

@joe248 joe248 commented Sep 26, 2019

Description:

Also fixed a bug where preset_mode was returning None instead of PRESET_NONE

Related issue (if applicable): fixes #26851

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@awarecan ?

@awarecan
Copy link
Copy Markdown
Contributor

@balloob has better knowledge about this change.

@pvizeli pvizeli merged commit b88772e into home-assistant:dev Sep 27, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nest - Changing preset mode to 'none' sets operation mode to 'auto'

5 participants