Revert Nest HVAC mode when disabling Eco mode#26934
Merged
Merged
Conversation
MartinHjelmare
approved these changes
Sep 26, 2019
pvizeli
approved these changes
Sep 27, 2019
Contributor
|
@balloob has better knowledge about this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Also fixed a bug where preset_mode was returning None instead of PRESET_NONE
Related issue (if applicable): fixes #26851
Checklist:
tox. Your PR cannot be merged unless tests pass