Reorg device automation#26880
Merged
Merged
Conversation
balloob
requested review from
a team,
Adminiuga,
Kane610 and
dmulcahey
as code owners
emontnemery
reviewed
Sep 24, 2019
|
|
||
| async def async_get_actions(hass, device_id, domain): | ||
| """List device actions.""" | ||
| print("YO") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Custom component developers that started playing with device automations only: we have restructured how integrations can expose their device triggers/conditions/actions. Instead of 1 platform
device_automation.pyit's nowdevice_action.py,device_trigger.py,device_condition.py.The method to attach a device trigger has been updated from
async_triggertoasync_attach_triggerto better reflect what is going on.Description:
When I was creating #26871 I realized that device automation files are getting pretty long, pretty fast. I also realized that there is a pretty clean cut possible by separating triggers, conditions and actions. This does so.
I will update #26871 to also have three different scaffolding templates.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: