Skip to content

Allow passing None as input_text config#26409

Merged
andrewsayre merged 1 commit into
devfrom
input-text-no-config
Sep 4, 2019
Merged

Allow passing None as input_text config#26409
andrewsayre merged 1 commit into
devfrom
input-text-no-config

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Sep 3, 2019

Breaking Change:

Description:

Allow setting no variables for input_text

input_text:
  some_input:

Related issue (if applicable): fixes #26264

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner September 3, 2019 23:36
@andrewsayre andrewsayre merged commit 53720c5 into dev Sep 4, 2019
@delete-merged-branch delete-merged-branch Bot deleted the input-text-no-config branch September 4, 2019 01:56
@lock lock Bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewsayre andrewsayre andrewsayre approved these changes

Assignees

No one assigned

Labels

cla-signed core has-tests integration: input_text small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[input-text] can't create input_text entity without any configuration variables.

3 participants

@balloob @andrewsayre @homeassistant