Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for meteoalarm handling encoding #24528

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Fix for meteoalarm handling encoding #24528

merged 2 commits into from
Jun 14, 2019

Conversation

rolfberkenbosch
Copy link
Contributor

Description:

This is a fix for encoding, meteoalarm uses ISO* and home-assistant utf-8.

Related issue (if applicable): fixes #23943

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned rolfberkenbosch Jun 14, 2019
@rolfberkenbosch rolfberkenbosch changed the title Dev meteoalarm Fix for meteoalarm handling encoding Jun 14, 2019
Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cgarwood cgarwood merged commit d8f5e9b into home-assistant:dev Jun 14, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
@rolfberkenbosch rolfberkenbosch deleted the dev-meteoalarm branch July 12, 2019 05:55
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meteoalarm PT not available
4 participants