Expose specific device_class for Velux covers #24279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blinds, Rollingshutters and Awnings did not set their respective device_class attribute Previously they would all appear as device_class "window"
homeassistant
added
integration: velux
small-pr
|
Hey there @Julius2342, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
fabaff
approved these changes
Jun 3, 2019
Julius2342
approved these changes
Jun 3, 2019
OttoWinter
reviewed
Jun 3, 2019
| if isinstance(self.node, RollerShutter): | ||
| return 'shutter' | ||
| if isinstance(self.node, Awning): | ||
| return 'awning' |
There was a problem hiding this comment.
I think this should have an explicit return None at the end in case none of the if cases match
fallback device class is always 'window' in the event we have an unknown cover type
OttoWinter
approved these changes
Jun 4, 2019
|
The pipeline is blocked bc of two trivial linter errors: @gibman : may you change them? |
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
* Update cover.py Blinds, Rollingshutters and Awnings did not set their respective device_class attribute Previously they would all appear as device_class "window" * fallback device class is always 'window' fallback device class is always 'window' in the event we have an unknown cover type * trailing whitespace removed, trimmed as well * Update cover.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blinds, Rollingshutters and Awnings did not set their respective device_class attribute
Previously they would all appear as device_class "window"
Breaking Change:
Description:
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: