Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code_arm_required to manual alarm with MQTT #22641

Merged
merged 3 commits into from
Jun 17, 2019
Merged

Add code_arm_required to manual alarm with MQTT #22641

merged 3 commits into from
Jun 17, 2019

Conversation

JumpMaster
Copy link

@JumpMaster JumpMaster commented Apr 1, 2019

Description:

Add code_arm_required to the manual alarm with mqtt as per the mqtt alarm. This option bypasses the code check if code_arm_required is false.

Related issue (if applicable): fixes #22263

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9087

Example entry for configuration.yaml (if applicable):

alarm_control_panel:
  - platform: manual_mqtt
    state_topic: home/alarm
    command_topic: home/alarm/set
    pending_time: 30
    delay_time: 20
    trigger_time: 4
    code_arm_required: False

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@JumpMaster JumpMaster requested a review from a team as a code owner April 2, 2019 06:38
@JumpMaster
Copy link
Author

I've included changed to both mqtt alarms and init.py to fix issue 22263. This is due to more-info-alarm_control_panel.js not having visibility of code_arm_required.

@fabaff fabaff changed the title add code_arm_required to manual alarm with mqtt Add code_arm_required to manual alarm with MQTT Apr 4, 2019
@emontnemery
Copy link
Contributor

emontnemery commented Apr 6, 2019

Related: #22618

@emontnemery
Copy link
Contributor

@JumpMaster Changes to the base component should be approved in an architecture issue.
Can you please open an issue here and explain why the new property is needed: https://github.com/home-assistant/architecture

@JumpMaster
Copy link
Author

@JumpMaster Changes to the base component should be approved in an architecture issue.
Can you please open an issue here and explain why the new property is needed: https://github.com/home-assistant/architecture

Thanks. I've raised issue 189

@balloob balloob merged commit f722a6c into home-assistant:dev Jun 17, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code_arm_required: false , arm buttons still greyed out , code field still visible
5 participants