Skip to content

Update rova component with suffix for house number#21182

Merged
cgarwood merged 2 commits into
home-assistant:devfrom
GidoHakvoort:rova-update
Feb 21, 2019
Merged

Update rova component with suffix for house number#21182
cgarwood merged 2 commits into
home-assistant:devfrom
GidoHakvoort:rova-update

Conversation

@GidoHakvoort
Copy link
Copy Markdown
Contributor

@GidoHakvoort GidoHakvoort commented Feb 18, 2019 •
edited
Loading

Add house_number_suffix to configuration

Description:

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8624

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: rova
    zip_code: ZIP_CODE
    house_number: HOUSE_NUMBER
    house_number_suffix: HOUSE_NUMBER_SUFFIX

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@GidoHakvoort
Update rova component with release rova release 0.1.0
b5702c5 
Add house_number_suffix to configuration
@ghost ghost added the in progress label Feb 18, 2019
GidoHakvoort added a commit to GidoHakvoort/home-assistant.io that referenced this pull request Feb 18, 2019
@GidoHakvoort
Add suffix to house_number
a4af553 
**Description:**

**Pull request in [home-assistant](https://github.com/home-assistant/home-assistant) (if applicable):** home-assistant/core#21182
@GidoHakvoort GidoHakvoort mentioned this pull request Feb 18, 2019
Merged
2 tasks
Kane610
Kane610 approved these changes Feb 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

rohankapoorcom
rohankapoorcom reviewed Feb 19, 2019
View reviewed changes
Comment thread homeassistant/components/sensor/rova.py Outdated
@GidoHakvoort GidoHakvoort reopened this Feb 19, 2019
@ghost ghost added in progress and removed in progress labels Feb 19, 2019
cgarwood pushed a commit to home-assistant/home-assistant.io that referenced this pull request Feb 21, 2019
@GidoHakvoort @cgarwood
Add suffix to house_number (#8624)
bc9c8a2 
* Add suffix to house_number

**Description:**

**Pull request in [home-assistant](https://github.com/home-assistant/home-assistant) (if applicable):** home-assistant/core#21182

* Update sensor.rova.markdown
@cgarwood cgarwood merged commit e764d94 into home-assistant:dev Feb 21, 2019
@ghost ghost removed the in progress label Feb 21, 2019
@balloob balloob mentioned this pull request Mar 6, 2019
Merged
@GidoHakvoort GidoHakvoort deleted the rova-update branch March 5, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohankapoorcom rohankapoorcom rohankapoorcom left review comments

@Kane610 Kane610 Kane610 approved these changes

Assignees

No one assigned

Labels

cla-signed integration: rova small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GidoHakvoort @rohankapoorcom @Kane610 @cgarwood @homeassistant