Skip to content

Fix hue retry crash#21083

Merged
balloob merged 3 commits into
devfrom
fix-hue-retry-crash
Feb 15, 2019
Merged

Fix hue retry crash#21083
balloob merged 3 commits into
devfrom
fix-hue-retry-crash

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 15, 2019

Description:

If Hue would need to retry connection, subsequent tries would crash because we were using hass.data[DOMAIN] for both config and bridge. Also, if unloading and setting up same host again, the YAML config would be lost.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned balloob Feb 15, 2019
@ghost ghost added the in progress label Feb 15, 2019
@balloob balloob added this to the 0.88.0 milestone Feb 15, 2019
@balloob balloob merged commit 1130ccb into dev Feb 15, 2019
@ghost ghost removed the in progress label Feb 15, 2019
@delete-merged-branch delete-merged-branch Bot deleted the fix-hue-retry-crash branch February 15, 2019 16:43
balloob added a commit that referenced this pull request Feb 15, 2019
* Fix Hue retry crash

* Fix hue retry crash

* Fix tests
@balloob balloob mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants