Skip to content

Add traccar scan_interval configuration option#21079

Merged
MartinHjelmare merged 4 commits into
home-assistant:devfrom
lapy:dev
Feb 17, 2019
Merged

Add traccar scan_interval configuration option#21079
MartinHjelmare merged 4 commits into
home-assistant:devfrom
lapy:dev

Conversation

@lapy
Copy link
Copy Markdown
Contributor

@lapy lapy commented Feb 14, 2019

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8618

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: traccar
    host: hostname
    port: 8072
    ssl: true
    username: admin
    password: password
    scan_interval: 00:00:05

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @lapy,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Comment thread homeassistant/components/device_tracker/traccar.py Outdated
Comment thread homeassistant/components/device_tracker/traccar.py Outdated
@home-assistant home-assistant deleted a comment from houndci-bot Feb 17, 2019
Comment thread homeassistant/components/device_tracker/traccar.py Outdated
Comment thread homeassistant/components/device_tracker/traccar.py Outdated
@MartinHjelmare MartinHjelmare changed the title Added scan_interval configuration option Add scan_interval configuration option Feb 17, 2019
@MartinHjelmare MartinHjelmare changed the title Add scan_interval configuration option Add traccar scan_interval configuration option Feb 17, 2019
@ludeeus
Copy link
Copy Markdown
Member

ludeeus commented Feb 17, 2019

Wouldn't the interval_seconds from the device_tracker component give the same as this?

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Feb 17, 2019

No, the traccar platform calls async_see to inform the component of seen devices. The component is not scanning for the traccar platform.

Comment thread homeassistant/components/device_tracker/traccar.py Outdated
Comment thread homeassistant/components/device_tracker/traccar.py Outdated
Co-Authored-By: lapy <lapy@users.noreply.github.com>
@ludeeus
Copy link
Copy Markdown
Member

ludeeus commented Feb 17, 2019

Looks fine by me now, but I have been "out of the game" lately, so will let @MartinHjelmare continue his great job here :D

@lapy
Copy link
Copy Markdown
Contributor Author

lapy commented Feb 17, 2019

Thanks to both of you! :)

Just a heads up: I have another pull request to do shortly after this is closed 😆

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinHjelmare MartinHjelmare merged commit 4e7cfc9 into home-assistant:dev Feb 17, 2019
@ghost ghost removed the in progress label Feb 17, 2019
@balloob balloob mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants