Skip to content

Set ZHA device availability on new join#21066

Merged
dmulcahey merged 2 commits into
home-assistant:devfrom
dmulcahey:dm/zha-available-on-new-join
Feb 15, 2019
Merged

Set ZHA device availability on new join#21066
dmulcahey merged 2 commits into
home-assistant:devfrom
dmulcahey:dm/zha-available-on-new-join

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

Fix device availability on new joins

@ghost ghost assigned dmulcahey Feb 14, 2019
@ghost ghost added the in progress label Feb 14, 2019
@dmulcahey dmulcahey added this to the 0.88.0 milestone Feb 14, 2019
Adminiuga
Adminiuga previously approved these changes Feb 14, 2019
Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the tests, otherwise looks good!

@Adminiuga Adminiuga dismissed their stale review February 14, 2019 19:15

need to fix the tests

@dmulcahey
Copy link
Copy Markdown
Contributor Author

dmulcahey commented Feb 15, 2019

They just need to rerun... happens a lot NVM... I do have stuff to fix

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when build passes.

@dmulcahey dmulcahey merged commit 3a6a246 into home-assistant:dev Feb 15, 2019
@ghost ghost removed the in progress label Feb 15, 2019
balloob pushed a commit that referenced this pull request Feb 15, 2019
* set availability on device join

* fix new join test
@dmulcahey dmulcahey deleted the dm/zha-available-on-new-join branch February 15, 2019 22:35
@balloob balloob mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants