HomematicIP fix cover direction#20901
Merged
amelchio merged 3 commits intoFeb 11, 2019
Merged
Conversation
homeassistant
added
cla-signed
integration: homematicip_cloud
small-pr
ghost
added
the
worm-ee
changed the title
worm-ee
changed the title
andrewsayre
requested changes
Feb 10, 2019
Member
andrewsayre
left a comment
andrewsayre
left a comment
There was a problem hiding this comment.
Thank you for this fix! Just a couple suggestions that will greatly improve maintainability!
andrewsayre
approved these changes
Feb 10, 2019
Member
|
Can be merged once build completes |
Contributor
|
In which version did you merged it? Unfortunately in 0.89dev it has still the wrong direction. |
Merged
|
Have installed the official 0.89.1 release - The problem is not fixed yet in the release as far as I can see. |
Member
|
Please open an issue if you suspect a bug. If you need help please use our help channels: Merged PRs should not be used for support or bug reports. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix for the inverted cover direction.
**Related issue (if applicable): see comments: #19794 (comment)
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.