Skip to content

Set GTFS icon by route type#20876

Merged
andrewsayre merged 1 commit into
home-assistant:devfrom
renemarc:gtfs-icon-by-route-type
Feb 9, 2019
Merged

Set GTFS icon by route type#20876
andrewsayre merged 1 commit into
home-assistant:devfrom
renemarc:gtfs-icon-by-route-type

Conversation

@renemarc
Copy link
Copy Markdown
Contributor

@renemarc renemarc commented Feb 8, 2019

Description:

This PR expands GTFS sensor icons from the current single one to an array of 8 depending on route type:

  • Tram/light train: mdi:tram
  • Subway: mdi:subway
  • Train: mdi:train
  • Bus: mdi:bus
  • Ferry: mdi:ferry
  • Cable car: mdi:train-variant
  • Gondola: mdi:gondola
  • Funicular: mdi:stairs

Source: https://developers.google.com/transit/gtfs/reference/#routestxt

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost added the in progress label Feb 8, 2019
@renemarc renemarc force-pushed the gtfs-icon-by-route-type branch from ab200d4 to 0434eeb Compare February 8, 2019 19:41
Comment thread homeassistant/components/sensor/gtfs.py Outdated
@renemarc renemarc force-pushed the gtfs-icon-by-route-type branch from 0434eeb to f901303 Compare February 8, 2019 20:51
@andrewsayre andrewsayre merged commit 9db9a81 into home-assistant:dev Feb 9, 2019
@ghost ghost removed the in progress label Feb 9, 2019
@balloob balloob mentioned this pull request Feb 20, 2019
@renemarc renemarc deleted the gtfs-icon-by-route-type branch April 1, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants