Avoid unnecessary commands in Vizio update function#20867
Merged
Conversation
Member
|
What do you mean with "I'm hopeful". Did you not test these changes locally? |
Contributor
Author
|
I'm using this code and it works. I don't know if it fixes that error because I don't see it very often, maybe once a week on average, and I don't know what the cause is. But whether or not it fixes that error, this is just a small PR to clean up the code -- there's no need to get further attributes when the state is off or unknown. We also don't need 3 lines to do what can be done in 1 line with a list comprehension |
Contributor
Author
|
I've been using this component for a week and have yet to see that error. |
Contributor
Author
|
@balloob it's been almost 3 weeks and I haven't seen that error once. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
If the power is off, we don't need to check the
_volume_level,_current_input, and_available_inputsattributes; we can just set them toNone.I'm hopeful that this can help me avoid errors of the form (this occurs in pyvizio when trying to get the volume level):
Related issue (if applicable):
Pull request in home-assistant.io with documentation (if applicable):
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: